Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

14 oc post prob #16

Merged
merged 103 commits into from
Oct 13, 2023
Merged

14 oc post prob #16

merged 103 commits into from
Oct 13, 2023

Conversation

audreyyeoCH
Copy link
Collaborator

Pull Request

audreyyeoCH and others added 30 commits August 14, 2023 17:53
@audreyyeoCH
cleaning up dbetabinom
50ef5b1
@audreyyeoCH
removed rounding, not needed
4342b5a
@audreyyeoCH
rmarkdown language and assert for dbetabinom
b095ae6
@audreyyeoCH
changed x and m to number instead of numeric
889e97d
@audreyyeoCH
test
2eafdc5
@audreyyeoCH
pbetaMix function and test
9dc428b
@audreyyeoCH
added new tests and changed documentation
dd1d8c4
@audreyyeoCH
upper case for test_that comments and more tests for qbeta
6d7f478
@audreyyeoCH
Merge branch 'main' into 9_pbeta
d520ff0
@audreyyeoCH
test_thats for pbetaMix and qbetaMix
0b361e3
@audreyyeoCH
tidy syntax and last checks
8b20f72
@audreyyeoCH
tidy syntax and last checks
b0c2218
@audreyyeoCH
Merge remote-tracking branch 'origin/9_pbeta' into 9_pbeta
9f53521
@audreyyeoCH @danielinteractive
Update R/dbetabinom.R
5384c3d 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@dependabot-preview
[skip actions] Roxygen Man Pages Auto Update
f5403fa
@audreyyeoCH @danielinteractive
Update R/dbetabinom.R
0dd2bab 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update R/dbetabinom.R
ca0236f 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update R/dbetabinom.R
9cf54d0 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update R/dbetabinom.R
2eb3bd2 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update R/dbetabinom.R
c08435f 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update R/dbetabinom.R
e36facd 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update R/dbetabinom.R
f45d2f0 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update examples/pbetaMix.R
0505982 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH
p and q inputs
469ed6e
@audreyyeoCH
q,p changes
1abea50
@audreyyeoCH @danielinteractive
Update R/dbetabinom.R
b7b523c 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@dependabot-preview
[skip actions] Roxygen Man Pages Auto Update
34a663b
@audreyyeoCH
documentation to reflect p and q changes
f384100
@audreyyeoCH
Merge remote-tracking branch 'origin/9_pbeta' into 9_pbeta
f0d5d00
@audreyyeoCH
amending qt
b9e50b2
@audreyyeoCH audreyyeoCH marked this pull request as draft October 11, 2023 13:18
danielinteractive
danielinteractive reviewed Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @audreyyeoCH , almost there! see last comments below

R/ocPostprob.R Outdated Show resolved Hide resolved
R/ocPostprob.R Outdated Show resolved Hide resolved
R/ocPostprob.R Outdated Show resolved Hide resolved
R/ocPostprob.R Outdated Show resolved Hide resolved
R/postprob.R Outdated Show resolved Hide resolved
R/postprob.R Outdated Show resolved Hide resolved
tests/testthat/test-ocPostprob.R Outdated Show resolved Hide resolved
tests/testthat/test-ocPostprob.R Outdated Show resolved Hide resolved
tests/testthat/test-ocPostprob.R Outdated Show resolved Hide resolved
tests/testthat/test-ocPostprob.R Outdated Show resolved Hide resolved
audreyyeoCH and others added 9 commits October 12, 2023 09:15
@audreyyeoCH
clean
bd78bbe
@audreyyeoCH @danielinteractive
Update R/ocPostprob.R
971264f 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update R/ocPostprob.R
ff8aa37 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update R/ocPostprob.R
6f3a999 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update R/ocPostprob.R
8990c36 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update R/postprob.R
8923010 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update R/postprob.R
3820c91 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update tests/testthat/test-ocPostprob.R
ec14b6d 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH
clean
0c5202e
@audreyyeoCH audreyyeoCH marked this pull request as ready for review October 12, 2023 12:57
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023 •
edited
Loading

🧪 Test coverage: 10.97%

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ---------------
R/betadiff.R                54      54  0.00%    21-98
R/boundsPostprob.R          31      31  0.00%    35-74
R/boundsPredprob.R          28      28  0.00%    40-77
R/dbetabinom.R              54       6  88.89%   34, 69, 141-145
R/helpers.R                 17      15  11.76%   10-57
R/oc2.R                    162     162  0.00%    99-336
R/oc3.R                    146     146  0.00%    97-314
R/ocPostprob.R              93       4  95.70%   232-235
R/ocPostprobDist.R          61      61  0.00%    59-130
R/ocPredprob.R              53      53  0.00%    68-138
R/ocPredprobDist.R          63      63  0.00%    70-149
R/ocRctPostprobDist.R      107     107  0.00%    81-224
R/ocRctPredprobDist.R      104     104  0.00%    86-227
R/plotBeta.R               107     107  0.00%    16-174
R/plotBounds.R              52      52  0.00%    37-94
R/plotDecision.R            79      79  0.00%    19-139
R/plotOc.R                  15      15  0.00%    16-36
R/postprob.R                29       1  96.55%   104
R/postprobDist.R            65      65  0.00%    56-151
R/predprob.R                25      25  0.00%    48-91
R/predprobDist.R            90      90  0.00%    81-222
R/runShinyPhase1b.R          4       4  0.00%    8-13
R/sumbetadiff.R             63      63  0.00%    27-104
R/sumTable.R                20      20  0.00%    25-48
TOTAL                     1522    1355  10.97%

Diff against main

Filename            Stmts    Miss  Cover
----------------  -------  ------  --------
R/dbetabinom.R        +12     -36  +88.89%
R/ocPostprob.R        +42     -47  +95.70%
R/postprob.R          +10     -18  +96.55%
R/postprobDist.R       +4      +4  +100.00%
TOTAL                 +68     -97  +10.83%

Results for commit: 9c1ada1

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

danielinteractive
danielinteractive approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @audreyyeoCH , looks good, just one last minor comment, afterwards good to merge

tests/testthat/test-ocPostprob.R Outdated Show resolved Hide resolved
@audreyyeoCH
Copy link
Collaborator Author

Thanks @danielinteractive for the comments and review! At the moment the changes are made but tt says merging is blocked

@audreyyeoCH audreyyeoCH merged commit b1ad258 into main Oct 13, 2023
15 checks passed
@audreyyeoCH audreyyeoCH deleted the 14_ocPostProb branch October 13, 2023 08:40
@audreyyeoCH audreyyeoCH mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielinteractive danielinteractive danielinteractive approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@audreyyeoCH @danielinteractive