Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up pbetaMix and qbetaMix #9 #10

Merged
merged 53 commits into from
Aug 31, 2023
Merged

Clean up pbetaMix and qbetaMix #9 #10

merged 53 commits into from
Aug 31, 2023

Conversation

audreyyeoCH
Copy link
Collaborator

@audreyyeoCH audreyyeoCH commented Aug 24, 2023

closes #9

@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2023

🧪 $Test coverage: 1.84%$

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  --------------
R/betadiff.R                54      54  0.00%    21-98
R/boundsPostprob.R          31      31  0.00%    35-74
R/boundsPredprob.R          28      28  0.00%    40-77
R/dbetabinom.R              54      29  46.30%   34, 68, 91-142
R/helpers.R                 17      15  11.76%   10-57
R/oc2.R                    162     162  0.00%    99-336
R/oc3.R                    146     146  0.00%    97-314
R/ocPostprob.R              51      51  0.00%    54-113
R/ocPostprobDist.R          61      61  0.00%    59-130
R/ocPredprob.R              53      53  0.00%    68-138
R/ocPredprobDist.R          63      63  0.00%    70-149
R/ocRctPostprobDist.R      107     107  0.00%    81-224
R/ocRctPredprobDist.R      104     104  0.00%    86-227
R/plotBeta.R               107     107  0.00%    16-174
R/plotBounds.R              52      52  0.00%    37-94
R/plotDecision.R            79      79  0.00%    19-139
R/plotOc.R                  15      15  0.00%    16-36
R/postprob.R                20      20  0.00%    25-92
R/postprobDist.R            65      65  0.00%    56-151
R/predprob.R                25      25  0.00%    48-91
R/predprobDist.R            90      90  0.00%    81-222
R/runShinyPhase1b.R          4       4  0.00%    8-13
R/sumbetadiff.R             63      63  0.00%    27-104
R/sumTable.R                20      20  0.00%    25-48
TOTAL                     1471    1444  1.84%

Diff against main

Filename            Stmts    Miss  Cover
----------------  -------  ------  --------
R/dbetabinom.R        +12     -13  +46.30%
R/postprob.R           +1      +1  +100.00%
R/postprobDist.R       +4      +4  +100.00%
TOTAL                 +17      -8  +1.70%

Results for commit: 08e62af

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2023

Unit Tests Summary

  1 files    2 suites   0s ⏱️
14 tests 14 ✔️ 0 💤 0
17 runs  17 ✔️ 0 💤 0

Results for commit 1a03d33.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @audreyyeoCH ! please see below

R/dbetabinom.R Outdated Show resolved Hide resolved
R/dbetabinom.R Outdated Show resolved Hide resolved
R/dbetabinom.R Outdated Show resolved Hide resolved
R/dbetabinom.R Outdated Show resolved Hide resolved
R/dbetabinom.R Outdated Show resolved Hide resolved
R/dbetabinom.R Outdated Show resolved Hide resolved
R/dbetabinom.R Show resolved Hide resolved
R/dbetabinom.R Outdated Show resolved Hide resolved
examples/pbetaMix.R Outdated Show resolved Hide resolved
inst/WORDLIST Show resolved Hide resolved
audreyyeoCH and others added 11 commits August 28, 2023 14:26
Co-authored-by: Daniel Sabanes Bove <[email protected]>
Co-authored-by: Daniel Sabanes Bove <[email protected]>
Co-authored-by: Daniel Sabanes Bove <[email protected]>
Co-authored-by: Daniel Sabanes Bove <[email protected]>
Co-authored-by: Daniel Sabanes Bove <[email protected]>
Co-authored-by: Daniel Sabanes Bove <[email protected]>
Co-authored-by: Daniel Sabanes Bove <[email protected]>
Co-authored-by: Daniel Sabanes Bove <[email protected]>
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@danielinteractive danielinteractive self-assigned this Aug 29, 2023
audreyyeoCH and others added 2 commits August 29, 2023 11:36
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH
Copy link
Collaborator Author

thanks @audreyyeoCH , please see below. Also I think we will need to update the introduction.Rmd vignette (probably because now we have different argument names than before) since currently its build fails

will do so, shall I send as separate PR ?

@danielinteractive
Copy link
Collaborator

thanks @audreyyeoCH , please see below. Also I think we will need to update the introduction.Rmd vignette (probably because now we have different argument names than before) since currently its build fails

will do so, shall I send as separate PR ?

no, we have to do this in this PR

@audreyyeoCH audreyyeoCH merged commit 168f3e4 into main Aug 31, 2023
21 checks passed
@danielinteractive danielinteractive deleted the 9_pbeta branch August 31, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up pbetaMix and qbetaMix
2 participants