Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brierScore supports logical events #439

Merged
merged 1 commit into from
Feb 21, 2025
Merged

brierScore supports logical events #439

merged 1 commit into from
Feb 21, 2025

Conversation

gowerc
Copy link
Collaborator

@gowerc gowerc commented Feb 20, 2025

Copy link
Contributor

badge

Code Coverage Summary

Filename                           Stmts    Miss  Cover    Missing
-------------------------------  -------  ------  -------  --------------------------------
R/brier_score.R                      167       0  100.00%
R/DataJoint.R                         76       2  97.37%   264, 270
R/DataLongitudinal.R                 119       1  99.16%   244
R/DataSubject.R                       85       1  98.82%   142
R/DataSurvival.R                      98       0  100.00%
R/defaults.R                          10       6  40.00%   18-57, 84
R/generics.R                          33       4  87.88%   52, 382, 402, 457
R/Grid.R                              27       1  96.30%   173
R/GridEven.R                          32       0  100.00%
R/GridEvent.R                         22       0  100.00%
R/GridFixed.R                         30       0  100.00%
R/GridGrouped.R                       52       0  100.00%
R/GridManual.R                        23       3  86.96%   78-80
R/GridObserved.R                      20       0  100.00%
R/GridPopulation.R                    31       4  87.10%   61, 69-71
R/GridPrediction.R                    36       6  83.33%   83, 91-95
R/JointModel.R                       129      10  92.25%   148-153, 203, 207, 249, 295, 301
R/JointModelSamples.R                 66       0  100.00%
R/link_generics.R                     16       4  75.00%   59, 76, 91, 106
R/Link.R                              62       4  93.55%   200-203
R/LinkComponent.R                     19       3  84.21%   88, 120-121
R/LongitudinalClaretBruno.R           90       6  93.33%   168-172, 187
R/LongitudinalGSF.R                   95       0  100.00%
R/LongitudinalModel.R                 19       0  100.00%
R/LongitudinalQuantities.R            71       0  100.00%
R/LongitudinalRandomSlope.R           44       5  88.64%   102-106
R/LongitudinalSteinFojo.R             86       5  94.19%   159-163
R/Parameter.R                         14       0  100.00%
R/ParameterList.R                     42       1  97.62%   184
R/Prior.R                            270       6  97.78%   547, 691-705
R/Promise.R                           25       0  100.00%
R/Quantities.R                        60       0  100.00%
R/QuantityGeneratorPopulation.R       22       0  100.00%
R/QuantityGeneratorPrediction.R       48       0  100.00%
R/QuantityGeneratorSubject.R          19       0  100.00%
R/settings.R                          12      12  0.00%    55-69
R/SimGroup.R                           5       0  100.00%
R/SimJointData.R                      72       1  98.61%   103
R/SimLongitudinal.R                    5       2  60.00%   22, 40
R/SimLongitudinalClaretBruno.R        74       0  100.00%
R/SimLongitudinalGSF.R                80       0  100.00%
R/SimLongitudinalRandomSlope.R        42       0  100.00%
R/SimLongitudinalSteinFojo.R          69       0  100.00%
R/SimSurvival.R                      116       0  100.00%
R/StanModel.R                         15       0  100.00%
R/StanModule.R                       176       6  96.59%   192-193, 235, 246, 383, 411
R/SurvivalExponential.R               10       0  100.00%
R/SurvivalGamma.R                     13       0  100.00%
R/SurvivalLoglogistic.R               11       0  100.00%
R/SurvivalModel.R                     19       0  100.00%
R/SurvivalQuantities.R               170       1  99.41%   125
R/SurvivalWeibullPH.R                 13       0  100.00%
R/utilities.R                        144       2  98.61%   13, 335
R/zzz.R                               29      26  10.34%   4-8, 10-31, 38-47
TOTAL                               3133     122  96.11%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 48ddc1a

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

Unit Tests Summary

    1 files    180 suites   5m 56s ⏱️
  158 tests   146 ✅ 12 💤 0 ❌
1 099 runs  1 086 ✅ 13 💤 0 ❌

Results for commit 48ddc1a.

Copy link
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
JointModelSamples 💚 $30.63$ $-1.36$ $0$ $0$ $0$ $0$
compile 💔 $4.35$ $+2.44$ $0$ $0$ $0$ $0$
extract_quantities 💔 $1.59$ $+6.29$ $0$ $0$ $0$ $0$
misc_models 💔 $6.66$ $+1.55$ $0$ $0$ $0$ $0$
model_multi_chain 💔 $0.01$ $+23.14$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
Grid 💚 $45.57$ $-1.82$ Grid_objects_work_with_QuantityGenerator_and_QuantityCollapser
GridPrediction 💚 $121.70$ $-5.17$ GridPrediction_works_as_expected_for_Survival_models
JointModelSamples 💚 $30.63$ $-1.36$ print_works_as_expected_for_JointModelSamples
LongitudinalRandomSlope 💔 $23.28$ $+1.69$ Print_method_for_LongitudinalRandomSlope_works_as_expected
SurvivalQuantities 💚 $31.30$ $-3.42$ SurvivalQuantities_and_autoplot.SurvivalQuantities_works_as_expected
brierScore 💔 $2.93$ $+9.56$ brierScore_SurvivalQuantities_returns_same_results_as_survreg
brierScore 👶 $+0.00$ brierScore_works_on_logical_events_438
compile 💔 $4.35$ $+2.44$ compileStanModel_doesn_t_error_if_the_directory_doesn_t_exist
extract_quantities 💔 $1.59$ $+6.29$ extract_quantities_works_as_expected
misc_models 💔 $6.66$ $+1.55$ Longitudinal_Model_doesn_t_print_sampler_rejection_messages
model_multi_chain 💔 $0.01$ $+23.14$ Can_recover_known_distribution_parameters_from_random_slope_model_when_using_multiple_chains
stan_functions 💚 $30.20$ $-26.08$ GSF_SLD_function_works_as_expected

Results for commit fe573e6

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @gowerc !

@gowerc gowerc merged commit 626ee20 into main Feb 21, 2025
20 checks passed
@gowerc gowerc deleted the 438-fix-brierScore branch February 21, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brierScore() fails for logical event indicator in OS dataset, while everything else works just fine
3 participants