Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support truncated prior distributions #430

Merged
merged 6 commits into from
Feb 3, 2025
Merged

Support truncated prior distributions #430

merged 6 commits into from
Feb 3, 2025

Conversation

gowerc
Copy link
Collaborator

@gowerc gowerc commented Jan 31, 2025

Copy link
Contributor

github-actions bot commented Jan 31, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
JointModelSamples 💔 $8.25$ $+20.43$ $0$ $-1$ $0$ $0$
compile 💚 $6.68$ $-6.24$ $0$ $0$ $0$ $0$
extract_quantities 💚 $7.88$ $-3.71$ $0$ $0$ $0$ $0$
misc_models 💚 $11.41$ $-6.87$ $0$ $0$ $0$ $0$
model_multi_chain 💚 $45.17$ $-43.01$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
Grid 💚 $102.23$ $-59.93$ Grid_objects_work_with_QuantityGenerator_and_QuantityCollapser
GridPrediction 💔 $112.83$ $+2.12$ GridPrediction_works_as_expected_for_Survival_models
JointModelSamples 💔 $8.25$ $+20.43$ print_works_as_expected_for_JointModelSamples
LongitudinalClaretBruno 💚 $1460.22$ $-1454.09$ LongitudinalClaretBruno_works_as_expected_with_default_arguments
LongitudinalGSF 💚 $710.84$ $-703.75$ LongitudinalGSF_works_as_expected_with_default_arguments
LongitudinalQuantiles 💚 $46.57$ $-36.60$ Test_that_LongitudinalQuantities_works_as_expected
LongitudinalRandomSlope 💚 $72.58$ $-52.11$ Print_method_for_LongitudinalRandomSlope_works_as_expected
LongitudinalSteinFojo 💚 $1395.56$ $-1388.02$ LongitudinalSteinFojo_works_as_expected_with_default_arguments
SurvivalExponential 💚 $23.62$ $-22.03$ Can_load_and_compile_SurvivalExponential_model
SurvivalGamma 💚 $185.08$ $-183.67$ Print_method_for_SurvivalGamma_works_as_expected
SurvivalLoglogistic 💚 $41.09$ $-39.62$ Can_load_and_compile_SurvivalLogLogistic_model
SurvivalQuantities 💚 $91.86$ $-86.20$ SurvivalQuantities_and_autoplot.SurvivalQuantities_works_as_expected
SurvivalWeibullPH 💚 $11.50$ $-9.86$ Print_method_for_SurvivalWeibullPH_works_as_expected
brierScore 💔 $17.64$ $+15.36$ brierScore_SurvivalQuantities_returns_same_results_as_survreg
brms_compare 💚 $319.91$ $-319.84$ jmpost_and_brms_get_similar_loo_for_longitudinal_models
compile 💚 $6.68$ $-6.24$ compileStanModel_doesn_t_error_if_the_directory_doesn_t_exist
extract_quantities 💚 $7.88$ $-3.71$ extract_quantities_works_as_expected
misc_models 💚 $11.41$ $-6.87$ Longitudinal_Model_doesn_t_print_sampler_rejection_messages
model_multi_chain 💚 $45.17$ $-43.01$ Can_recover_known_distribution_parameters_from_random_slope_model_when_using_multiple_chains
stan_functions 💚 $33.69$ $-7.46$ GSF_SLD_function_works_as_expected

Results for commit 7e03e27

♻️ This comment has been updated with latest results.

@gowerc
Copy link
Collaborator Author

gowerc commented Feb 3, 2025

@gravesti - Apologies for the delay in getting the tests fixed up I managed to brick my local R installation and took forever to fix :( Hopefully this should be ready for review now.

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Unit Tests Summary

    1 files    179 suites   5m 40s ⏱️
  157 tests   145 ✅ 12 💤 0 ❌
1 098 runs  1 085 ✅ 13 💤 0 ❌

Results for commit 20b1ab3.

Copy link
Collaborator

@gravesti gravesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gowerc !

@gowerc gowerc merged commit 5a76e76 into main Feb 3, 2025
23 checks passed
@gowerc gowerc deleted the 429-truncated-priors branch February 3, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Truncation missing for standard deviation parameters?
2 participants