-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Gamma Survival Model #413
Conversation
Code Coverage Summary
Diff against main
Results for commit: fbc9f29 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 175 suites 5m 58s ⏱️ Results for commit 023f09f. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit ea0d677 ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Query on the stan definition of the hazard @gowerc , otherwise looks good!
I had another comment but I resolved it. I was confused why the log hazard was defined differently in the stan code. But I found it correct and due to the stan function a normalising term. |
Ah yer apologies I probs should have made a comment to explain that stan automatically adds in the normalising term which isn't done in the R equivalent code. |
Closes #411
Apologies though I have committed the cardinal sin of adding in a few additional unrelated changes that I spotted whilst developing this which include: