Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unscaled variance for SF model #405

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Add unscaled variance for SF model #405

merged 3 commits into from
Aug 20, 2024

Conversation

gowerc
Copy link
Collaborator

@gowerc gowerc commented Aug 13, 2024

Closes the SF part of #403

@gowerc gowerc requested a review from gravesti August 13, 2024 15:50
Copy link
Contributor

github-actions bot commented Aug 13, 2024

badge

Code Coverage Summary

Filename                           Stmts    Miss  Cover    Missing
-------------------------------  -------  ------  -------  --------------------------------
R/brier_score.R                      167       0  100.00%
R/DataJoint.R                         76       2  97.37%   264, 270
R/DataLongitudinal.R                 119       1  99.16%   244
R/DataSubject.R                       85       1  98.82%   142
R/DataSurvival.R                      98       0  100.00%
R/defaults.R                          10       6  40.00%   18-57, 84
R/generics.R                          34       4  88.24%   52, 396, 416, 471
R/Grid.R                              27       1  96.30%   173
R/GridEven.R                          32       0  100.00%
R/GridEvent.R                         22       0  100.00%
R/GridFixed.R                         30       0  100.00%
R/GridGrouped.R                       52       0  100.00%
R/GridManual.R                        23       3  86.96%   78-80
R/GridObserved.R                      20       0  100.00%
R/GridPopulation.R                    31       4  87.10%   61, 69-71
R/GridPrediction.R                    36       6  83.33%   83, 91-95
R/JointModel.R                       126      10  92.06%   146-151, 201, 205, 247, 293, 299
R/JointModelSamples.R                 66       0  100.00%
R/link_generics.R                     16       4  75.00%   59, 76, 91, 106
R/Link.R                              62       4  93.55%   200-203
R/LinkComponent.R                     19       3  84.21%   88, 120-121
R/LongitudinalClaretBruno.R           89       6  93.26%   164-168, 183
R/LongitudinalGSF.R                   95       0  100.00%
R/LongitudinalModel.R                 19       0  100.00%
R/LongitudinalQuantities.R            71       0  100.00%
R/LongitudinalRandomSlope.R           44       5  88.64%   102-106
R/LongitudinalSteinFojo.R             86       5  94.19%   159-163
R/Parameter.R                         14       0  100.00%
R/ParameterList.R                     42       1  97.62%   184
R/Prior.R                            254       6  97.64%   507, 651-665
R/Promise.R                           25       0  100.00%
R/Quantities.R                        60       0  100.00%
R/QuantityGeneratorPopulation.R       22       0  100.00%
R/QuantityGeneratorPrediction.R       48       0  100.00%
R/QuantityGeneratorSubject.R          19       0  100.00%
R/settings.R                          12      12  0.00%    55-69
R/SimGroup.R                           5       0  100.00%
R/SimJointData.R                      72       1  98.61%   103
R/SimLongitudinal.R                    5       2  60.00%   22, 40
R/SimLongitudinalClaretBruno.R        72       0  100.00%
R/SimLongitudinalGSF.R                80       0  100.00%
R/SimLongitudinalRandomSlope.R        42       0  100.00%
R/SimLongitudinalSteinFojo.R          69       0  100.00%
R/SimSurvival.R                      104       0  100.00%
R/StanModel.R                         15       0  100.00%
R/StanModule.R                       176       6  96.59%   192-193, 235, 246, 383, 411
R/SurvivalExponential.R               10       0  100.00%
R/SurvivalLoglogistic.R               11       0  100.00%
R/SurvivalModel.R                     19       0  100.00%
R/SurvivalQuantities.R               170       1  99.41%   125
R/SurvivalWeibullPH.R                 11       0  100.00%
R/utilities.R                        144       2  98.61%   13, 335
R/zzz.R                               28      25  10.71%   3, 8-12, 14-35, 47
TOTAL                               3084     121  96.08%

Diff against main

Filename                        Stmts    Miss  Cover
----------------------------  -------  ------  --------
R/LongitudinalGSF.R                +1       0  +100.00%
R/LongitudinalSteinFojo.R          +1       0  +0.07%
R/SimLongitudinalGSF.R             +2       0  +100.00%
R/SimLongitudinalSteinFojo.R       +2       0  +100.00%
TOTAL                              +6       0  +0.01%

Results for commit: 7aead6f

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Aug 13, 2024

Unit Tests Summary

    1 files    166 suites   6m 32s ⏱️
  144 tests   139 ✅ 5 💤 0 ❌
1 063 runs  1 057 ✅ 6 💤 0 ❌

Results for commit 7aead6f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 13, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
model_multi_chain 💔 $1.43$ $+1.05$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
Grid 💔 $52.20$ $+1.40$ Grid_objects_work_with_QuantityGenerator_and_QuantityCollapser
GridPrediction 💔 $122.37$ $+1.98$ GridPrediction_works_as_expected_for_Survival_models
LongitudinalGSF 👶 $+0.00$ Can_recover_known_distributional_parameters_from_unscaled_variance_GSF_model
LongitudinalGSF 👶 $+0.00$ Unscaled_variance_GSF_mode_pass_the_parser
LongitudinalSteinFojo 👶 $+0.00$ Can_recover_known_distributional_parameters_from_unscaled_variance_SF_model
LongitudinalSteinFojo 💔 $6.78$ $+1.21$ LongitudinalSteinFojo_works_as_expected_with_default_arguments
LongitudinalSteinFojo 👶 $+0.00$ Unscaled_variance_SF_mode_pass_the_parser
SurvivalLoglogistic 💔 $16.79$ $+1.02$ sim_os_loglogistic_is_consistant_with_flexsurv
model_multi_chain 💔 $1.43$ $+1.05$ Can_recover_known_distribution_parameters_from_random_slope_model_when_using_multiple_chains

Results for commit bf7d7a0

♻️ This comment has been updated with latest results.

@gowerc gowerc merged commit 7f3312d into main Aug 20, 2024
23 checks passed
@gowerc gowerc deleted the 403-variance-option-sf branch August 20, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants