Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unscaled variance option for GSF #404

Merged
merged 4 commits into from
Aug 20, 2024
Merged

add unscaled variance option for GSF #404

merged 4 commits into from
Aug 20, 2024

Conversation

gowerc
Copy link
Collaborator

@gowerc gowerc commented Aug 13, 2024

Closes the GSF part of #403

@gowerc gowerc requested a review from gravesti August 13, 2024 15:11
Copy link
Contributor

github-actions bot commented Aug 13, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
misc_models 💔 $7.60$ $+1.18$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
Grid 💚 $53.84$ $-53.54$ Grid_objects_work_with_QuantityGenerator_and_QuantityCollapser
GridPrediction 💔 $121.73$ $+10.25$ GridPrediction_works_as_expected_for_Survival_models
LongitudinalGSF 👶 $+0.00$ Can_recover_known_distributional_parameters_from_unscaled_variance_GSF_model
LongitudinalGSF 👶 $+0.00$ Unscaled_variance_GSF_mode_pass_the_parser
LongitudinalQuantiles 💔 $2.15$ $+55.97$ Test_that_LongitudinalQuantities_works_as_expected
LongitudinalRandomSlope 💚 $12.16$ $-1.59$ Print_method_for_LongitudinalRandomSlope_works_as_expected
SurvivalExponential 💔 $22.46$ $+1.73$ SurvivalExponential_can_recover_true_parameter_including_covariates_
SurvivalLoglogistic 💔 $12.98$ $+3.86$ sim_os_loglogistic_is_consistant_with_flexsurv
SurvivalQuantities 💔 $3.88$ $+21.26$ SurvivalQuantities_and_autoplot.SurvivalQuantities_works_as_expected
SurvivalWeibullPH 💔 $8.58$ $+18.07$ Print_method_for_SurvivalWeibullPH_works_as_expected
brierScore 💚 $34.74$ $-28.92$ brierScore_SurvivalQuantities_returns_same_results_as_survreg
misc_models 💔 $7.60$ $+1.18$ Longitudinal_Model_doesn_t_print_sampler_rejection_messages
stan_functions 💔 $27.90$ $+2.69$ GSF_SLD_function_works_as_expected

Results for commit 18daf4b

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 13, 2024

badge

Code Coverage Summary

Filename                           Stmts    Miss  Cover    Missing
-------------------------------  -------  ------  -------  --------------------------------
R/brier_score.R                      167       0  100.00%
R/DataJoint.R                         76       2  97.37%   264, 270
R/DataLongitudinal.R                 119       1  99.16%   244
R/DataSubject.R                       85       1  98.82%   142
R/DataSurvival.R                      98       0  100.00%
R/defaults.R                          10       6  40.00%   18-57, 84
R/generics.R                          34       4  88.24%   52, 396, 416, 471
R/Grid.R                              27       1  96.30%   173
R/GridEven.R                          32       0  100.00%
R/GridEvent.R                         22       0  100.00%
R/GridFixed.R                         30       0  100.00%
R/GridGrouped.R                       52       0  100.00%
R/GridManual.R                        23       3  86.96%   78-80
R/GridObserved.R                      20       0  100.00%
R/GridPopulation.R                    31       4  87.10%   61, 69-71
R/GridPrediction.R                    36       6  83.33%   83, 91-95
R/JointModel.R                       126      10  92.06%   146-151, 201, 205, 247, 293, 299
R/JointModelSamples.R                 66       0  100.00%
R/link_generics.R                     16       4  75.00%   59, 76, 91, 106
R/Link.R                              62       4  93.55%   200-203
R/LinkComponent.R                     19       3  84.21%   88, 120-121
R/LongitudinalClaretBruno.R           89       6  93.26%   164-168, 183
R/LongitudinalGSF.R                   95       0  100.00%
R/LongitudinalModel.R                 19       0  100.00%
R/LongitudinalQuantities.R            71       0  100.00%
R/LongitudinalRandomSlope.R           44       5  88.64%   102-106
R/LongitudinalSteinFojo.R             85       5  94.12%   155-159
R/Parameter.R                         14       0  100.00%
R/ParameterList.R                     42       1  97.62%   184
R/Prior.R                            254       6  97.64%   507, 651-665
R/Promise.R                           25       0  100.00%
R/Quantities.R                        60       0  100.00%
R/QuantityGeneratorPopulation.R       22       0  100.00%
R/QuantityGeneratorPrediction.R       48       0  100.00%
R/QuantityGeneratorSubject.R          19       0  100.00%
R/settings.R                          12      12  0.00%    55-69
R/SimGroup.R                           5       0  100.00%
R/SimJointData.R                      72       1  98.61%   103
R/SimLongitudinal.R                    5       2  60.00%   22, 40
R/SimLongitudinalClaretBruno.R        72       0  100.00%
R/SimLongitudinalGSF.R                80       0  100.00%
R/SimLongitudinalRandomSlope.R        42       0  100.00%
R/SimLongitudinalSteinFojo.R          67       0  100.00%
R/SimSurvival.R                      104       0  100.00%
R/StanModel.R                         15       0  100.00%
R/StanModule.R                       176       6  96.59%   192-193, 235, 246, 383, 411
R/SurvivalExponential.R               10       0  100.00%
R/SurvivalLoglogistic.R               11       0  100.00%
R/SurvivalModel.R                     19       0  100.00%
R/SurvivalQuantities.R               170       1  99.41%   125
R/SurvivalWeibullPH.R                 11       0  100.00%
R/utilities.R                        144       2  98.61%   13, 335
R/zzz.R                               28      25  10.71%   3, 8-12, 14-35, 47
TOTAL                               3081     121  96.07%

Diff against main

Filename                  Stmts    Miss  Cover
----------------------  -------  ------  --------
R/LongitudinalGSF.R          +1       0  +100.00%
R/SimLongitudinalGSF.R       +2       0  +100.00%
TOTAL                        +3       0  +0.00%

Results for commit: 8deebf5

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Aug 13, 2024

Unit Tests Summary

    1 files    164 suites   7m 1s ⏱️
  142 tests   138 ✅ 4 💤 0 ❌
1 061 runs  1 056 ✅ 5 💤 0 ❌

Results for commit 8deebf5.

♻️ This comment has been updated with latest results.

@gowerc gowerc merged commit 7d4f9a3 into main Aug 20, 2024
23 checks passed
@gowerc gowerc deleted the 403-variance-option branch August 20, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants