Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set lower limit to 0 #394

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Set lower limit to 0 #394

merged 2 commits into from
Aug 12, 2024

Conversation

gowerc
Copy link
Collaborator

@gowerc gowerc commented Jul 31, 2024

Closes #393

@gowerc gowerc requested a review from gravesti July 31, 2024 10:16
Copy link
Contributor

github-actions bot commented Jul 31, 2024

Unit Tests Summary

    1 files    162 suites   6m 25s ⏱️
  140 tests   137 ✅ 3 💤 0 ❌
1 059 runs  1 055 ✅ 4 💤 0 ❌

Results for commit d74af6b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jul 31, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
JointModelSamples 💚 $33.11$ $-1.26$ $0$ $0$ $0$ $0$
compile 💔 $3.26$ $+2.44$ $0$ $0$ $0$ $0$
extract_quantities 💚 $2.65$ $-2.63$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
Grid 💚 $54.00$ $-5.95$ Grid_objects_work_with_QuantityGenerator_and_QuantityCollapser
GridPrediction 💚 $127.65$ $-4.98$ GridPrediction_works_as_expected_for_Survival_models
JointModelSamples 💚 $33.11$ $-1.26$ print_works_as_expected_for_JointModelSamples
LongitudinalQuantiles 💔 $4.98$ $+3.50$ Test_that_LongitudinalQuantities_works_as_expected
LongitudinalRandomSlope 💚 $7.26$ $-3.45$ Print_method_for_LongitudinalRandomSlope_works_as_expected
SimSurvival 💔 $2.91$ $+1.07$ SimSurvivalExponential_creates_a_dataset_with_the_correct_parameter
SurvivalExponential 💚 $24.55$ $-2.35$ SurvivalExponential_can_recover_true_parameter_including_covariates_
SurvivalLoglogistic 💔 $18.42$ $+3.69$ sim_os_loglogistic_is_consistant_with_flexsurv
SurvivalQuantities 💔 $3.68$ $+30.53$ SurvivalQuantities_and_autoplot.SurvivalQuantities_works_as_expected
brierScore 💚 $37.30$ $-36.45$ brierScore_SurvivalQuantities_returns_same_results_as_survreg
compile 💔 $3.26$ $+2.44$ compileStanModel_doesn_t_error_if_the_directory_doesn_t_exist
extract_quantities 💚 $2.65$ $-2.63$ extract_quantities_works_as_expected
stan_functions 💚 $29.54$ $-1.08$ GSF_SLD_function_works_as_expected

Results for commit 120e8a8

♻️ This comment has been updated with latest results.

Copy link
Contributor

badge

Code Coverage Summary

Filename                           Stmts    Miss  Cover    Missing
-------------------------------  -------  ------  -------  --------------------------------
R/brier_score.R                      167       0  100.00%
R/DataJoint.R                         76       2  97.37%   264, 270
R/DataLongitudinal.R                 119       1  99.16%   244
R/DataSubject.R                       85       1  98.82%   142
R/DataSurvival.R                      98       0  100.00%
R/defaults.R                          10       6  40.00%   18-57, 84
R/generics.R                          34       4  88.24%   52, 396, 416, 471
R/Grid.R                              27       1  96.30%   173
R/GridEven.R                          32       0  100.00%
R/GridEvent.R                         22       0  100.00%
R/GridFixed.R                         30       0  100.00%
R/GridGrouped.R                       52       0  100.00%
R/GridManual.R                        23       3  86.96%   78-80
R/GridObserved.R                      20       0  100.00%
R/GridPopulation.R                    31       4  87.10%   61, 69-71
R/GridPrediction.R                    36       6  83.33%   83, 91-95
R/JointModel.R                       126      10  92.06%   146-151, 201, 205, 247, 293, 299
R/JointModelSamples.R                 66       0  100.00%
R/link_generics.R                     16       4  75.00%   59, 76, 91, 106
R/Link.R                              62       4  93.55%   200-203
R/LinkComponent.R                     19       3  84.21%   88, 120-121
R/LongitudinalClaretBruno.R           89       6  93.26%   164-168, 183
R/LongitudinalGSF.R                   94       0  100.00%
R/LongitudinalModel.R                 19       0  100.00%
R/LongitudinalQuantities.R            71       0  100.00%
R/LongitudinalRandomSlope.R           44       5  88.64%   102-106
R/LongitudinalSteinFojo.R             85       5  94.12%   155-159
R/Parameter.R                         14       0  100.00%
R/ParameterList.R                     42       1  97.62%   184
R/Prior.R                            254       6  97.64%   507, 651-665
R/Promise.R                           25       0  100.00%
R/Quantities.R                        60       0  100.00%
R/QuantityGeneratorPopulation.R       22       0  100.00%
R/QuantityGeneratorPrediction.R       48       0  100.00%
R/QuantityGeneratorSubject.R          19       0  100.00%
R/settings.R                          12      12  0.00%    55-69
R/SimGroup.R                           5       0  100.00%
R/SimJointData.R                      72       1  98.61%   103
R/SimLongitudinal.R                    5       2  60.00%   22, 40
R/SimLongitudinalClaretBruno.R        52       0  100.00%
R/SimLongitudinalGSF.R                62       0  100.00%
R/SimLongitudinalRandomSlope.R        42       0  100.00%
R/SimLongitudinalSteinFojo.R          52       0  100.00%
R/SimSurvival.R                      104       0  100.00%
R/StanModel.R                         15       0  100.00%
R/StanModule.R                       176       6  96.59%   192-193, 235, 246, 383, 411
R/SurvivalExponential.R               10       0  100.00%
R/SurvivalLoglogistic.R               11       0  100.00%
R/SurvivalModel.R                     19       0  100.00%
R/SurvivalQuantities.R               170       1  99.41%   125
R/SurvivalWeibullPH.R                 11       0  100.00%
R/utilities.R                        144       2  98.61%   13, 335
R/zzz.R                               28      25  10.71%   3, 8-12, 14-35, 47
TOTAL                               3027     121  96.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: d74af6b

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@gowerc gowerc merged commit 5b50387 into main Aug 12, 2024
20 checks passed
@gowerc gowerc deleted the 392-set-0 branch August 12, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set lower value to 0
2 participants