-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements growth link function #330
Conversation
Unit Tests Summary 1 files 42 suites 8m 15s ⏱️ Results for commit 43ceccb. |
Unit Test Performance Difference
Additional test case details
Results for commit 960c9eb ♻️ This comment has been updated with latest results. |
Code Coverage Summary
Diff against main
Results for commit: 43ceccb Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, I think this just means that there is not a lot of information in the data about the link coefficient...
Partially addresses #170
Only thing that is making me a bit nervous about this is that the confidence intervals for this link parameter in my testing seem all most excessively wide. For example with ~12 observations per subject and 800 subjects and a real value of 3 I'm getting:
That might not seem so bad but then compare it to the other model parameters:
The confidence intervals are noticeably tighter. Admittedly this isn't really a unique problem for the growth link as it happens with all of them, but still makes me a little nervous... maybe its fine ?
Either way the full link testing code takes ages to run so I've marked it as "not for cran" meaning it will only run in our twice a month CRON job. I done a parser check though, e.g. it checks stans static parser to ensure the stan code is syntactically valid.