-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Stein-Fojo Model #265
Add Stein-Fojo Model #265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gowerc , any chance we can exploit the relationship between SF and GSF? E.g. SF being a special case of GSF?
@danielinteractive - I mean almost certainly yes, but when I first attempted to go down that route it just felt like the dynamic code (particularly in the Stan + Jinja side of things) was more of a hassle than just the simple c&p + name changes. |
Unit Tests Summary 1 files 35 suites 4m 33s ⏱️ Results for commit ac3fc67. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit fbb1422 ♻️ This comment has been updated with latest results. |
Code Coverage Summary
Diff against main
Results for commit: ac3fc67 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Ok for now then. I guess as a future idea one could in general enable "constant" priors as it seems brms also has which is then dynamically generating corresponding transformed parameters code. This could be useful in general and as a side product make GSF with constant prior on the mixture weight give the SF model. |
Closes #171