Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change LICENSE.md to plain text LICENSE #260

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Change LICENSE.md to plain text LICENSE #260

merged 2 commits into from
Feb 20, 2024

Conversation

cicdguy
Copy link
Collaborator

@cicdguy cicdguy commented Feb 19, 2024

To prevent linter complaints and to keep the license format consistent across Roche packages.

@cicdguy cicdguy requested a review from gowerc February 19, 2024 13:58
@cicdguy cicdguy self-assigned this Feb 19, 2024
Copy link
Contributor

github-actions bot commented Feb 19, 2024

badge

Code Coverage Summary

Filename                       Stmts    Miss  Cover    Missing
---------------------------  -------  ------  -------  -------------------------------------
R/brier_score.R                  166       0  100.00%
R/DataJoint.R                     76       2  97.37%   264, 270
R/DataLongitudinal.R             119       1  99.16%   245
R/DataSubject.R                   69       1  98.55%   124
R/DataSurvival.R                  74       1  98.65%   146
R/defaults.R                      13       7  46.15%   27, 45-84, 111
R/generics.R                      16       1  93.75%   69
R/JointModel.R                   119       9  92.44%   114-116, 166, 170, 212, 258, 264, 270
R/JointModelSamples.R             54       0  100.00%
R/Link.R                          18       0  100.00%
R/LinkGSF.R                       69      13  81.16%   116-128
R/LinkNone.R                       5       1  80.00%   36
R/LinkRandomSlope.R               11       0  100.00%
R/LongitudinalGSF.R               56       0  100.00%
R/LongitudinalModel.R             17       0  100.00%
R/LongitudinalQuantities.R        85       8  90.59%   100-107
R/LongitudinalRandomSlope.R       20       0  100.00%
R/Parameter.R                     14       0  100.00%
R/ParameterList.R                 42       1  97.62%   184
R/Prior.R                        236       8  96.61%   480, 576, 588-606
R/Quantities.R                   105       0  100.00%
R/settings.R                      11      11  0.00%    40-53
R/simulations_gsf.R               41       0  100.00%
R/simulations_os.R                11       5  54.55%   35-39
R/simulations_rs.R                21       0  100.00%
R/simulations.R                   99       1  98.99%   122
R/StanModel.R                     15       0  100.00%
R/StanModule.R                   177       6  96.61%   199-200, 242, 253, 388, 416
R/SurvivalExponential.R           10       0  100.00%
R/SurvivalLoglogistic.R           11       0  100.00%
R/SurvivalModel.R                 19       0  100.00%
R/SurvivalQuantities.R           151       6  96.03%   173-178
R/SurvivalWeibullPH.R             11       0  100.00%
R/utilities.R                    145       1  99.31%   13
R/zzz.R                            2       2  0.00%    3-12
TOTAL                           2108      85  95.97%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 5d51788

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

Unit Tests Summary

  1 files   35 suites   5m 18s ⏱️
105 tests  80 ✅ 25 💤 0 ❌
780 runs  755 ✅ 25 💤 0 ❌

Results for commit 230651c.

Copy link
Contributor

github-actions bot commented Feb 19, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
JointModelSamples 💚 $31.79$ $-1.03$ $0$ $0$ $0$ $0$
LongitudinalGSF 💚 $620.14$ $-562.96$ $-5$ $+1$ $0$ $0$
LongitudinalQuantiles 💚 $44.01$ $-3.33$ $0$ $0$ $0$ $0$
SurvivalExponential 💚 $29.56$ $-2.95$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
JointModelSamples 💚 $31.79$ $-1.03$ smoke_test_for_JointModelSamples
LongitudinalGSF 💚 $590.27$ $-562.03$ Can_recover_known_distributional_parameters_from_a_full_GSF_joint_model
LongitudinalQuantiles 💚 $38.40$ $-3.14$ Test_that_LongitudinalQuantities_works_as_expected
SurvivalExponential 💚 $25.84$ $-2.63$ SurvivalExponential_can_recover_true_parameter_no_covariates_

Results for commit e75a7f0

♻️ This comment has been updated with latest results.

@danielinteractive
Copy link
Collaborator

Can we maybe just remove this? CRAN e.g. will ask later anyway when we don't have modifications in the file

@gowerc
Copy link
Collaborator

gowerc commented Feb 20, 2024

Changed the name down to LICENSE rather than LICENSE.md as that appears to also be consistent with our other packages and having it as .md was still triggering the superlinter.

@gowerc gowerc merged commit c3576a9 into main Feb 20, 2024
16 checks passed
@gowerc gowerc deleted the cicdguy-patch-1 branch February 20, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants