stopped deletion of snapshot files

Genentech · Jun 21, 2024 · 95b044d · 95b044d
1 parent e6fd6ff
commit 95b044d
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 6 deletions.
diff --git a/...urvival-plot-no-wrap-no-ci-km-ggplot2.svg → .../survival_plot/nowrap-noci-km-ggplot2.svg b/...urvival-plot-no-wrap-no-ci-km-ggplot2.svg → .../survival_plot/nowrap-noci-km-ggplot2.svg
diff --git a/.../survival-plot-with-no-wrap-and-no-ci.svg → ...that/_snaps/survival_plot/nowrap-noci.svg b/.../survival-plot-with-no-wrap-and-no-ci.svg → ...that/_snaps/survival_plot/nowrap-noci.svg
diff --git a/...l_plot/survival-plot-with-wrap-and-ci.svg → ...testthat/_snaps/survival_plot/wrap-ci.svg b/...l_plot/survival-plot-with-wrap-and-ci.svg → ...testthat/_snaps/survival_plot/wrap-ci.svg
diff --git a/tests/testthat/test-survival_plot.R b/tests/testthat/test-survival_plot.R
@@ -1,4 +1,10 @@
 
+## Code to re-run this from commandline
+# JMPOST_GRAPH_SNAPSHOT=TRUE \
+# NOT_CRAN=TRUE \
+# Rscript -e "devtools::load_all(); testthat::test_file('tests/testthat/test-survival_plot.R')"
+
+snap_dir <- file.path(testthat::test_path(), "_snaps", "survival_plot")
 
 test_that("survival_plot works as expected", {
 
@@ -64,9 +70,11 @@ test_that("survival_plot works as expected", {
         x_label = expression(thd[3])
     )
 
+
+    announce_snapshot_file(file.path(snap_dir, "wrap-ci.svg"))
     if (is_graph_snapshot_enabled()) {
         vdiffr::expect_doppelganger(
-            "survival_plot with wrap and ci",
+            "wrap-ci",
             p1
         )
     }
@@ -81,9 +89,10 @@ test_that("survival_plot works as expected", {
         x_label = expression(thd[3])
     )
 
+    announce_snapshot_file(file.path(snap_dir, "nowrap-noci.svg"))
     if (is_graph_snapshot_enabled()) {
         vdiffr::expect_doppelganger(
-            "survival_plot with no wrap and no ci",
+            "nowrap-noci",
             p2
         )
     }
@@ -100,10 +109,15 @@ test_that("survival_plot works as expected", {
         theme(legend.position = "bottom") +
         scale_y_continuous(trans = "sqrt")
 
+    announce_snapshot_file(file.path(snap_dir, "nowrap-noci-km-ggplot2.svg"))
     if (is_graph_snapshot_enabled()) {
         vdiffr::expect_doppelganger(
-            "survival_plot-no wrap + no ci + km + ggplot2 ",
+            "nowrap-noci-km-ggplot2",
             p3
         )
     }
+
+    # Null test so that its not considered as an empty test if the "JMPOST_GRAPH_SNAPSHOT"
+    # variable is not set
+    expect_equal(1, 1)
 })