Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lapis2)!: read data from SILO as NDJSON #742

Merged
merged 1 commit into from
Apr 18, 2024
Merged

feat(lapis2)!: read data from SILO as NDJSON #742

merged 1 commit into from
Apr 18, 2024

Conversation

fengelniederhammer
Copy link
Contributor

resolves #741

PR Checklist

  • [ ] All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@fengelniederhammer
Copy link
Contributor Author

End-to-end tests should become green as soon as GenSpectrum/LAPIS-SILO#388 is merged. Locally they work with the image of that branch.

chaoran-chen
chaoran-chen approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@chaoran-chen chaoran-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@fengelniederhammer fengelniederhammer merged commit 767b19d into main Apr 18, 2024
10 checks passed
@fengelniederhammer fengelniederhammer deleted the 741-accept-ndjson-data-from-silo branch April 18, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaoran-chen chaoran-chen chaoran-chen approved these changes

@pflanze pflanze Awaiting requested review from pflanze

@JonasKellerer JonasKellerer Awaiting requested review from JonasKellerer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accept NDJSON data from SILO
2 participants
@fengelniederhammer @chaoran-chen