Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lapis2): prefer zstd over gzip #739

Conversation

fengelniederhammer
Copy link
Contributor

resolves #738

Chrome now supports zstd compression, so it will set Accept-Encoding: gzip, deflate, br, zstd. In that case, we should prefer zstd, because it's usually faster and has better compression ratios.

PR Checklist

  • [ ] All necessary documentation has been adapted.
  • [ ] The implemented feature is covered by an appropriate test.

@corneliusroemer
Copy link
Contributor

I might have been wrong about it having higher compression ratios - I think they are pretty similar and sometimes worse for zstd, but the extra speed and reduced CPU load is worth losing something like a 5% increase in size (I think). People who want max compression can always ask for gzip only.

Copy link
Contributor

@JonasKellerer JonasKellerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (My chrome loads the data)

@fengelniederhammer fengelniederhammer merged commit 1fb67ac into main Apr 24, 2024
10 checks passed
@fengelniederhammer fengelniederhammer deleted the 738-enh-offer-zstd-encoding-for-pareto-superior-compression branch April 24, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Offer zstd encoding for pareto superior compression
3 participants