fixup! build(lapis2): use Release Please to generate releases

GenSpectrum · May 6, 2024 · 64c2e3f · 64c2e3f
1 parent 8d67486
commit 64c2e3f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/release-lapis2.yml b/.github/workflows/release-lapis2.yml
@@ -52,13 +52,14 @@ jobs:
           check-name: Build Docs Docker Image And Run E2E Tests
           repo-token: ${{ secrets.GITHUB_TOKEN }}
 
-      - name: Tag Already Built Image With Release Tags
+      - name: Tag Already Built Images With Release Tags
         if: ${{ steps.release.outputs.release_created }}
         run: |
           MAJOR=${{ steps.release.outputs.major }}
           MINOR=${{ steps.release.outputs.minor }}
           PATCH=${{ steps.release.outputs.patch }}
           TAGS=("$MAJOR.$MINOR" "$MAJOR.$MINOR.$PATCH")
+          # TODO (#add-ticket!!!!) include $MAJOR only for releases >= 1.0
           # TAGS=("$MAJOR" "$MAJOR.$MINOR" "$MAJOR.$MINOR.$PATCH") - don't include major-only for pre-1.0
           IMAGES=("${{ env.LAPIS_DOCKER_IMAGE_NAME }}" "${{ env.DOCS_DOCKER_IMAGE_NAME }}")
           

diff --git a/release-please-config.json b/release-please-config.json
@@ -2,7 +2,7 @@
     "include-component-in-tag": true,
     "packages": {
         "lapis2": {
-            "release-type": "java",
+            "release-type": "simple",
             "extra-files": [
                 "build.gradle"
             ]