Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding provenance record for arcs - fixes 227 #232

Conversation

olyoberdorf
Copy link
Contributor

Bias and flat handling has extra logic to record the calibrations in the provenance, beyond what the decorator does.

I added this for arcs.

@olyoberdorf olyoberdorf changed the title adding provenance record for arcs adding provenance record for arcs - fixes 227 Apr 14, 2021
@chris-simpson
Copy link
Contributor

Tests are failing. Some are regression tests, which is understandable since they will use the default inputs/references instead of the ones in the release/3.0.x branch, but some are not. Since all the tests pass on release/3.0.x I assume you've modified an outdated version of that branch. It would be helpful if you could merge in the more recent changes so we can confirm that no tests are failing unexpectedly.

@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #232 (fb0ab4a) into release/3.0.x (77de0cb) will increase coverage by 0.00%.
The diff coverage is 86.66%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/3.0.x     #232   +/-   ##
==============================================
  Coverage          45.44%   45.44%           
==============================================
  Files                263      263           
  Lines              22438    22442    +4     
==============================================
+ Hits               10196    10198    +2     
- Misses             12242    12244    +2     
Impacted Files Coverage Δ
geminidr/core/primitives_spect.py 20.23% <50.00%> (+0.07%) ⬆️
astrodata/provenance.py 100.00% <100.00%> (ø)
recipe_system/utils/decorators.py 84.10% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77de0cb...fb0ab4a. Read the comment docs.

@olyoberdorf olyoberdorf merged commit 65afc6a into release/3.0.x Jun 14, 2021
@olyoberdorf olyoberdorf deleted the bugfix/227_provenance_not_captured_for_distortion_correct_arcs branch June 14, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No information anywhere about which arc is being used during a GMOS LS reduction
2 participants