Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No information anywhere about which arc is being used during a GMOS LS reduction #227

Open
KathleenLabrie opened this issue Apr 14, 2021 · 0 comments · Fixed by #232
Open
Labels
component - calibration Calibration handling systems documentation 📚 Improvements or additions to documentation severity-routine Needs to be fixed urgency-medium Somewhat normal urgency
Milestone

Comments

@KathleenLabrie
Copy link
Contributor

An arc is required for QECorrect and distortionCorrect. Both call getProcessedArc. Nowhere in logs, in the headers, or in the provenance table is there a record of which processed arc was used.

getProcessedArc: The getProcessedBias and getProcessedFlat both list which calibration is being picked up for each input frames. This does not seem to happen for getProcessedArc and it needs to be fixed.

PROVENANCE table: The bias and the flat being used are recorded. But the arc is not. It really should.

Headers: While I personally would really like to see the name of the arc used in a header keyword, looking at the headers, I see that this is not done for the other calibrations. Yes, the info is (should be) in the provenance table. The list of inputs in a stack is in the headers though.

Executive summary: The name of the arc used must be recorded somewhere.

@KathleenLabrie KathleenLabrie added component - calibration Calibration handling systems documentation 📚 Improvements or additions to documentation severity-routine Needs to be fixed urgency-medium Somewhat normal urgency labels Apr 15, 2021
@KathleenLabrie KathleenLabrie added this to the v3.0.0 milestone Apr 15, 2021
@olyoberdorf olyoberdorf linked a pull request May 6, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component - calibration Calibration handling systems documentation 📚 Improvements or additions to documentation severity-routine Needs to be fixed urgency-medium Somewhat normal urgency
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant