Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add loop animation support to PresenceTransition #5725

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
import React from 'react';
import { Button, Center, PresenceTransition } from 'native-base';

export const Example = () => {
const [isOpen, setIsOpen] = React.useState(false);

return (
<Center>
<Button onPress={() => setIsOpen(!isOpen)} mb={20}>
{isOpen ? 'Hide' : 'Show'}
</Button>
<PresenceTransition
visible={isOpen}
initial={{ rotate: '0deg' }}
animate={{ rotate: '180deg', transition: { duration: 250 } }}
loop
>
<Center
mt="7"
bg="teal.500"
rounded="md"
w="200"
h="100"
_text={{ color: 'white' }}
>
Fade
</Center>
</PresenceTransition>
</Center>
);
};
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { storiesOf } from '@storybook/react-native';
import { withKnobs } from '@storybook/addon-knobs';
import Wrapper from './../../Wrapper';
import { Example as Fade } from './Fade';
import { Example as Loop } from './Loop';
import { Example as ScaleFade } from './ScaleFade';
import { Example as Slide } from './Slide';
import { Example as SlideWrapped } from './SlideWrapped';
Expand All @@ -14,6 +15,7 @@ storiesOf('Transitions', module)
.addDecorator(withKnobs)
.addDecorator((getStory: any) => <Wrapper>{getStory()}</Wrapper>)
.add('Fade', () => <Fade />)
.add('Loop', () => <Loop />)
.add('ScaleFade', () => <ScaleFade />)
.add('Slide', () => <Slide />)
.add('Slide wrapped inside parent', () => <SlideWrapped />)
Expand Down
12 changes: 9 additions & 3 deletions src/components/composites/Transitions/Transition.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ export const Transition = forwardRef(
exit,
style,
as,
loop,
...rest
}: ITransitionProps,
ref: any
Expand Down Expand Up @@ -105,16 +106,21 @@ export const Transition = forwardRef(
const startAnimation = animationState === 'entering' ? 1 : 0;

const transition = startAnimation ? entryTransition : exitTransition;

Animated.sequence([
let animation = Animated.sequence([
// @ts-ignore - delay is present in defaultTransitionConfig
Animated.delay(transition.delay),
Animated[transition.type ?? 'timing'](animateValue, {
toValue: startAnimation,
useNativeDriver: true,
...transition,
}),
]).start(() => {
]);

if (loop) {
animation = Animated.loop(animation);
}

animation.start(() => {
if (animationState === 'entering') {
setAnimationState('entered');
} else if (animationState === 'exiting') {
Expand Down
4 changes: 4 additions & 0 deletions src/components/composites/Transitions/types.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,10 @@ export interface ITransitionProps extends ViewProps {
* Determines whether to start the animation
*/
visible?: boolean;
/**
* Loops a given animation continuously
*/
loop?: boolean;

animationExited?: boolean;
children?: any;
Expand Down