Fixed Spacing in Path Bug on Windows #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @TitusSmith33 can you please move this PR forward through the review process? We need to get a review from one student technical leader and from two students who did not work on the fix. Thanks, I appreciate your contribution and your work in moving this PR through the process. |
Chezka109
approved these changes
Oct 31, 2024
hannahb09
approved these changes
Oct 31, 2024
AlishChhetri
approved these changes
Oct 31, 2024
execexam/main.py
Outdated
| @@ -285,7 +285,7 @@ def run( # noqa: PLR0913, PLR0915 | |||
| # build the command for running symbex; this tool can | |||
| # perform static analysis of Python source code and | |||
| # extract the code of a function inside of a file | |||
| command = f"symbex {test_name} -f {failing_test_path}" | |||
| command = f'symbex {test_name}" -f "{failing_test_path}"' | |||
There was a problem hiding this comment.
There’s a minor syntax issue in the command string. It appears that a double quote is missing at the beginning of {test_name}. The corrected line should be:
command = f'symbex "{test_name}" -f "{failing_test_path}"'
CalebKendra
approved these changes
Oct 31, 2024
PCain02
approved these changes
Nov 5, 2024
|
Hello @TitusSmith33 will you need to update your pyproject.toml file? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Contributors: Titus Smith
This PR is aimed at fixing Issue #36, which causes a stack trace on Windows 11 when running
execexamif a space exists anywhere in the directory path.This PR simply changes 1 line that is passed in
main.pyofexecexamwhen the path to a failing check is passed. Symbax previously handled paths separately if there was a space anywhere in the directory. For example, if you had the following path:user/documents/software engineering/exam_solutionthe program was splitting the path and trying to handle them one at a time rather than as one. This PR makes sure the failing path is quoted properly so that paths are handled as one, regardless of whether a space exists.This PR should not affect code coverage.
This PR was created and tested on a Windows 11 OS. I have tested this new implementation with a space in my path, and with no spaces in my path, and they both pass without causing a stack trace anymore.
Below is line 288 of
main.py, which is where I changed how paths are handled: