Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

made a get which first checks id then by name #61

Merged
merged 1 commit into from
May 23, 2024
Merged

made a get which first checks id then by name #61

merged 1 commit into from
May 23, 2024

Conversation

zmattes04
Copy link
Collaborator

@zmattes04 zmattes04 commented May 23, 2024 •
edited
Loading

Developer: Zach Mattes

Closes #60

Pull Request Summary

Added two requests in backend

  1. Get groupId then if that fails it trys get by groupName
  2. Get ItemId then if that fails it trys get by ItemName

Modifications

Edited itemroutes and grouproutes

Testing Considerations

Tested in boomerang

Pull Request Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit messages follows our guidelines
  • The developer name is specified
  • The summary is completed
  • Assign reviewers

Screenshots/Screencast

{put screenshots of your change, or even better a screencast displaying the functionality}

@zmattes04 zmattes04 linked an issue May 23, 2024 that may be closed by this pull request
Create search by name request in Backend #60
Closed
@zmattes04 zmattes04 requested review from SilveerDusk and jhagendoornCP and removed request for SilveerDusk and jhagendoornCP May 23, 2024 06:05
@zmattes04
Copy link
Collaborator Author

Passed CI Testing lets go

SilveerDusk
SilveerDusk approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@SilveerDusk SilveerDusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good and is a good way to create flexible get requests

@SilveerDusk SilveerDusk merged commit 3e060f9 into main May 23, 2024
2 of 3 checks passed
@jhagendoornCP jhagendoornCP deleted the 60-create-search-by-name-request-in-backend branch June 4, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SilveerDusk SilveerDusk SilveerDusk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create search by name request in Backend
2 participants
@zmattes04 @SilveerDusk