Sofija's Create my items page #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Please update the pr with your changes and screenshots of what it does. Also thought we were going to use the charka table for this page? Is the VStack just better? |
|
updated PR! |
|
@sofijadimitrijevic1 I went and fixed the merge conflicts, once its passing the CI testing then we can merge it! Looks like there are some prettier issues to start with. |
sofijadimitrijevic1
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer: Sofija Dimitrijevic
Closes #17 , #22
Pull Request Summary
Made frontend for items page and item group component page.
Modifications
ItemGroup.tsx is a chakra table with item name and description that also has 'More', 'Move', and 'Delete' buttons (which do not work because this needs to be connected to backend). Also tweaked that the buttons for each group line up with buttons from other groups so looks way cleaner.
ItemsPage.tsx uses the ItemGroup components in a VStack. Theres a button on top to 'switch to groups' page and also a (non functional) search bar
Testing Considerations
I need to learn to make jest tests for this today
Pull Request Checklist
Screenshots/Screencast