Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lots of changes #154

Merged

Conversation

zmattes04
Copy link
Collaborator

Developer: Zach

Closes #152

Pull Request Summary

So i did a lot
i updated the ui to look better and got rid of type, publicprivate and all the useless attributes from the frontend.
I made it so that the popovers stay on screen, and also other ui stuff i cant really rmemeber because im very tired.
Its good to merge tho because i tested the ui and it works. Oh i remember what i did, i added logic to properly state private/public items.

{Describe the purpose of your pull request}

Modifications

{list out the files created/modified and a brief description of what was changed}

Testing Considerations

{list out what you have tested and what the reviewer should verify}

Pull Request Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit messages follows our guidelines
  • The developer name is specified
  • The summary is completed
  • Assign reviewers

Screenshots/Screencast

{put screenshots of your change, or even better a screencast displaying the functionality}

@zmattes04 zmattes04 linked an issue Jun 4, 2024 that may be closed by this pull request
@zmattes04 zmattes04 requested a review from SilveerDusk June 4, 2024 05:04
Copy link
Collaborator

@SilveerDusk SilveerDusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@zmattes04 zmattes04 merged commit a5d0e80 into main Jun 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get rid of type on frontend and set default value
2 participants