Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User auth enforce #131

Merged
merged 5 commits into from
Jun 2, 2024
Merged

User auth enforce #131

merged 5 commits into from
Jun 2, 2024

Conversation

SilveerDusk
Copy link
Collaborator

Developer: Jason

Closes #user auth backend enforcing

Pull Request Summary

enforces user auth across the site
visitors will not be able to use api calls while signed out (no token)
visitors will not be able to visit any user only sites (attempts will redirect them to sign in)

Modifications

all routes, all api calls, frontend route useeffects

Testing Considerations

used postman for backend testing and navigated to each page signed in and signed out for frontend

Pull Request Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit messages follows our guidelines
  • The developer name is specified
  • The summary is completed
  • Assign reviewers

Screenshots/Screencast

@SilveerDusk SilveerDusk requested a review from jhagendoornCP June 2, 2024 16:28
Copy link
Collaborator

@jhagendoornCP jhagendoornCP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad we finally have this! thank you for updating all endpoints we have rn with the auth, looks good to me i say we merge

@SilveerDusk SilveerDusk merged commit 0300677 into main Jun 2, 2024
3 checks passed
@jhagendoornCP jhagendoornCP deleted the user-auth-enforce branch June 4, 2024 21:12
@SilveerDusk SilveerDusk self-assigned this Jun 6, 2024
@SilveerDusk SilveerDusk added this to the Milestone 3 milestone Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants