Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add baskets to individual group page #122

Merged
merged 3 commits into from
May 29, 2024

Conversation

sofijadimitrijevic1
Copy link
Collaborator

Developer: {Full Name}

Closes #116

Pull Request Summary

Basket components that are associated with a group now show up on each individual group page

Modifications

Modified IndividualGroupPage, made fetchBaskets function, added the baskets fetched to the basket placeholder on the page.

Testing Considerations

Tested that it correctly renders for general cases (zero baskets, one basket, more than one basket) (will need to write actual cypress tests for this)

Pull Request Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit messages follows our guidelines
  • The developer name is specified
  • The summary is completed
  • Assign reviewers

Screenshots/Screencast

{put screenshots of your change, or even better a screencast displaying the functionality}
Screenshot 2024-05-29 at 12 46 06 AM

Screen.Recording.2024-05-29.at.12.47.00.AM.mov

@sofijadimitrijevic1 sofijadimitrijevic1 linked an issue May 29, 2024 that may be closed by this pull request
@zmattes04
Copy link
Collaborator

looks good can we make it so where it says members it shows username instead of id. i feel like thats a pretty easy fix.

@SilveerDusk
Copy link
Collaborator

SilveerDusk commented May 29, 2024

Looks good! @sofijadimitrijevic1 Do the buttons work or is it just frontend rn?

@sofijadimitrijevic1
Copy link
Collaborator Author

@SilveerDusk it is just frontend

@zmattes04
Copy link
Collaborator

can we merge this to main so i can try to add my "add basket button somewhere?

@sofijadimitrijevic1 sofijadimitrijevic1 merged commit 883fae1 into main May 29, 2024
3 checks passed
@jhagendoornCP jhagendoornCP deleted the 116-add-baskets-to-individual-group-page branch June 4, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Baskets to Individual Group Page
4 participants