Marianna/1196/feedback feature

[Mdemenko1]

What (if any) features are you implementing?

Feedback feature for the issue #1196

Screenshare.-.2024-10-23.5_09_03.PM.mp4

• Update back end with newfeedback_links object

[sydney-devine]

Did we make that icon in house? Wondering if we can tweak it to give a little more padding in the circle because it looks a little odd. @Linda-Vu thoughts?

Also, I'd love for the pop-up to actually be a pop-up and float/hover on top, instead of pushing the page down when it opens. The jumping when the button gets clicked looks a bit odd.

[CalebPena]

Looks good, just a couple of code style suggestions.

Could you also run npm run format

[Linda-Vu]

Did we make that icon in house? Wondering if we can tweak it to give a little more padding in the circle because it looks a little odd. @Linda-Vu thoughts?

Also, I'd love for the pop-up to actually be a pop-up and float/hover on top, instead of pushing the page down when it opens. The jumping when the button gets clicked looks a bit odd.

@sydney-devine yep, these are the icons Sofia made for us that we shared with you on the ticket! @kc-accidental when you get a chance, could you generate another icon that has a bit more padding inside the circle like Sydney is asking for and share them here for @Mdemenko1 to use? thank you so much!

@Mdemenko1 for now, while you're waiting for the new icon, could you address the suggestion that Sydney made about preventing the page from jumping when the button is clicked?

thanks so much everyone!!! <3

[sydney-devine]

Did we make that icon in house? Wondering if we can tweak it to give a little more padding in the circle because it looks a little odd. @Linda-Vu thoughts?
Also, I'd love for the pop-up to actually be a pop-up and float/hover on top, instead of pushing the page down when it opens. The jumping when the button gets clicked looks a bit odd.

@sydney-devine yep, these are the icons Sofia made for us that we shared with you on the ticket! @kc-accidental when you get a chance, could you generate another icon that has a bit more padding inside the circle like Sydney is asking for and share them here for @Mdemenko1 to use? thank you so much!

@Mdemenko1 for now, while you're waiting for the new icon, could you address the suggestion that Sydney made about preventing the page from jumping when the button is clicked?

thanks so much everyone!!! <3

Thanks @Linda-Vu !

[kc-accidental]

Here are the icons with more padding ✨ Lmk if there's anything else! @Linda-Vu @sydney-devine

[sydney-devine]

Here are the icons with more padding ✨ Lmk if there's anything else! @Linda-Vu @sydney-devine

Thanks so much for the quick turnaround @kc-accidental - @Linda-Vu & @Mdemenko1 I vote we go with the second (orange outline) one since it's more in line with the rest of the icon library we have.

[Mdemenko1]

Updated behavior, please let me know what you think @sydney-devine @Linda-Vu @

Screenshare.-.2024-09-19.9_34_27.AM.mp4

[sydney-devine]

Updated behavior, please let me know what you think @sydney-devine @Linda-Vu @

Screenshare.-.2024-09-19.9_34_27.AM.mp4

Can we have it pop up above still and just hover over/overlay on the continue button? Kind of think it's odd having it pop up below. Only time it should really do that is if the user has scrolled down so far on the page there's no space above. @Linda-Vu thoughts?

[CalebPena]

Lets use position absolute to put the modal in the right spot.

[Linda-Vu]

Updated behavior, please let me know what you think @sydney-devine @Linda-Vu @
Screenshare.-.2024-09-19.9_34_27.AM.mp4

Can we have it pop up above still and just hover over/overlay on the continue button? Kind of think it's odd having it pop up below. Only time it should really do that is if the user has scrolled down so far on the page there's no space above. @Linda-Vu thoughts?

@sydney-devine is there a compromise where we have it hover a bit higher but never cover the "continue" button? @rickyctd and the rest of our team really want that call to action to never get obstructed for the user.

[sydney-devine]

Updated behavior, please let me know what you think @sydney-devine @Linda-Vu @
Screenshare.-.2024-09-19.9_34_27.AM.mp4

Can we have it pop up above still and just hover over/overlay on the continue button? Kind of think it's odd having it pop up below. Only time it should really do that is if the user has scrolled down so far on the page there's no space above. @Linda-Vu thoughts?

@sydney-devine is there a compromise where we have it hover a bit higher but never cover the "continue" button? @rickyctd and the rest of our team really want that call to action to never get obstructed for the user.

I just don't think popping up on the bottom is very standard behavior? And looks a bit odd. I get not wanting the call to action to be obstructed, but the user should also be able to close out of that pop-up if they don't want to wind up using it, etc.

What does this look like right now in mobile?? The most similar thing this can model after is probably the Send results link pop-up where it greys out the results. I kinda think if a user is opening the pop-up then it should show where it's standard then they have to close back out of it to continue?

[Linda-Vu]

Updated behavior, please let me know what you think @sydney-devine @Linda-Vu @
Screenshare.-.2024-09-19.9_34_27.AM.mp4

Can we have it pop up above still and just hover over/overlay on the continue button? Kind of think it's odd having it pop up below. Only time it should really do that is if the user has scrolled down so far on the page there's no space above. @Linda-Vu thoughts?

@sydney-devine is there a compromise where we have it hover a bit higher but never cover the "continue" button? @rickyctd and the rest of our team really want that call to action to never get obstructed for the user.

I just don't think popping up on the bottom is very standard behavior? And looks a bit odd. I get not wanting the call to action to be obstructed, but the user should also be able to close out of that pop-up if they don't want to wind up using it, etc.

What does this look like right now in mobile?? The most similar thing this can model after is probably the Send results link pop-up where it greys out the results. I kinda think if a user is opening the pop-up then it should show where it's standard then they have to close back out of it to continue?

@sydney-devine the "send my results" functionality is what I initially assumed this feature would mimic as well. That shifted for us during development when we got feedback from the team that the overlay functionality could be annoying to users, especially since feedback is an optional feature and not a core feature when compared to the "send my results" modal.

I think @rickyctd is away right now at some conferences, but I'd love to see what his perspective is when he returns!

@Mdemenko1 for now, could you show us what this looks like on mobile? otherwise, you can pause with the CSS/positioning on this modal until we reach a resolution! thank you for your flexibility <3

[CalebPena]

Looks good