Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the program name and desc for styling purposes #1234

Merged
merged 14 commits into from
Sep 6, 2024

Conversation

ivonne-hernandez
Copy link
Collaborator

@ivonne-hernandez ivonne-hernandez commented Aug 8, 2024

What (if anything) did you refactor?

  • I split the program name and description for styling purposes.

Were there any issues that arose?

  • I noticed that an ErrorMessage component does not render when the user selects Yes but then doesn't check any of the boxes.

Is there anything that you need from your teammate?

  • Please go through and make sure that nothing breaks.
  • I had to refactor the Confirmation component to account for the category_benefits schema. Please note that once this is approved, I'll have to go in and manually update all of these FM values.

Updated text and styling on step-8:
Screenshot 2024-08-08 at 4 12 59 PM

Updated Confirmation component:
Screenshot 2024-08-28 at 4 52 59 PM

@ivonne-hernandez ivonne-hernandez changed the base branch from main to dev August 8, 2024 22:16
@ivonne-hernandez ivonne-hernandez marked this pull request as draft August 16, 2024 16:00
@ivonne-hernandez ivonne-hernandez marked this pull request as ready for review August 28, 2024 20:20
@ivonne-hernandez ivonne-hernandez marked this pull request as draft August 28, 2024 21:05
@ivonne-hernandez ivonne-hernandez marked this pull request as ready for review August 28, 2024 22:49
@ivonne-hernandez ivonne-hernandez added the impact-high Significant possible impact on data, security or user experience. Req lead dev + 1 review. label Aug 28, 2024
src/Components/Confirmation/Confirmation.js Outdated Show resolved Hide resolved
src/Components/Confirmation/Confirmation.js Outdated Show resolved Hide resolved
@CalebPena CalebPena merged commit 680963e into dev Sep 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact-high Significant possible impact on data, security or user experience. Req lead dev + 1 review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants