Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1036: wip #351

Merged

Conversation

Mdemenko1
Copy link
Collaborator

@Mdemenko1 Mdemenko1 commented May 2, 2024

What (if any) features are you implementing?

Implementing dark/light mode

image

@Mdemenko1 Mdemenko1 marked this pull request as ready for review May 7, 2024 14:05
@Mdemenko1 Mdemenko1 requested a review from msrezaie May 7, 2024 14:05
Copy link
Collaborator

@msrezaie msrezaie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too sure on the positioning of the theme switch. One idea I was thinking of is to have the button be placed at the bottom of the sidebar and make the entire sidebar have the sticky property.
image

translations/static/js/theme.js Outdated Show resolved Hide resolved
translations/templates/base.html Outdated Show resolved Hide resolved
@msrezaie msrezaie self-requested a review May 8, 2024 19:41
Copy link
Collaborator

@msrezaie msrezaie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, awesome work!

@msrezaie msrezaie merged commit 799421d into feature/admin-&-translations-ui-rework May 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants