Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consolidate instrument page #406

Merged
merged 3 commits into from
Nov 13, 2024
Merged

consolidate instrument page #406

merged 3 commits into from
Nov 13, 2024

Conversation

bensonlee5
Copy link
Member

@bensonlee5 bensonlee5 commented Nov 6, 2024 •
edited
Loading

Description of Change

  • Consolidate instruments pages to a single one
  • Some language cleanup of instruments page
  • Moves the instrument page to its own folder

Reason

  • Makes navigation easier, since the left sidebar is pretty full already and the right sidebar is otherwise unused

@vercel Vercel
Copy link

vercel bot commented Nov 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website-docusaurus ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 6:22pm

@bensonlee5 bensonlee5 requested a review from ericsong November 6, 2024 02:13
@ericsong
Copy link
Contributor

ericsong commented Nov 6, 2024

LGTM, do you want to add it back to the sidebar with these changes?

@bensonlee5
Copy link
Member Author

LGTM, do you want to add it back to the sidebar with these changes?

yup will do, once the feature goes live. I'll also want to link to it from release notes when that comes out

@ericsong ericsong merged commit eeca2d1 into main Nov 13, 2024
3 checks passed
@ericsong ericsong deleted the upd-instrument-page branch November 13, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsong ericsong ericsong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bensonlee5 @ericsong