This repository has been archived by the owner on Jan 27, 2018. It is now read-only.
Allow custom HTDocs folder for PHP instances #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered an issue with using the plugin with my PHP instances because I had symlinked the htdocs folder to a different folder to secure the web application. Because of this the sftp client could not place the challenge file in the htdocs folder, as it cannot by default follow symlinks.
This edit adds an extra --letsencrypt-gandi:gandi-shs-htdocs option, which if used with a PHP instance allows a custom folder location to be specified. The ".well-known/acme-challenge" folders would then be created within the folder given.
I have tested this patch with my two vhosts which have htdocs symlinked and verified that it works.