-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color-coding operations #80
Open
distay0xGit
wants to merge
33
commits into
Gaming32:main
Choose a base branch
from
distay0xGit:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems good, but I do have a few optimizations in mind... (such as not creating an array from a keyset on every frame) |
@distay0xGit Can you fix the checkstyle and build issues? |
This is not a sorts PR. Can you please remove Explicium Sort? |
In desperate need of optimization, rough around the edges.
And a method for writing colors between auxarrays. Thanks for suggesting it, Control.
GitHub is being stubborn
Seriously, GitHub?
This is getting stupid
Git, what are you doing? |
We'll see if we can work out a better solution.
Git, what the heck?
oops! bad coding practice
AtomicInteger-related type changes I desperately want to avoid a conflict for and removing an interface from ArrayVlist
_why doesn't it want me to change the packages imported for ArrayVList_
the conflict checker is running off black magic and all the spells in it are specifically against pushing Groovy support into this PR
I just hope I can revert this weird hack after this PR is brought up to speed with all the changes in main
Could the custom color coding be a toggleable option? like to switch between color-coded operations and normal highlighting? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes ArrayV to allow operations to be color-coded, with a legend included, if given operations it is able to color-code.