add more receiver information fields to Event [#188816354] #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also clean up the React warnings on the donation form [#188816354]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Donation Tracker
Issue from Pivotal Tracker
https://www.pivotaltracker.com/story/show/188816354
Description of the Change
It's been requested that we add some additional tweaks to the Donate form. Easiest way to do that is add some additional receiver information fields on the Event itself. Then display them on the form.
As part of this I changed the 'solicit email' line to a simple checkbox.
Verification Process
Donated with and without the checkbox checked to ensure that the correct opt-in value was passed to the server.
All the other new values work. In the case of them being blank, it either shows nothing or the default string.