Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Donation Tracker
First of all, thank you for taking the time to contribute!
Please fill out the template below and check the following boxes:
No automated tests needed to be run, and the current tests still work with these changes applied.
Issue from Pivotal Tracker
Link to the issue from the public Pivotal Tracker that your change addresses. (Expand the story and click the link icon to copy the link to your clipboard.)
N/A
Description of the Change
This makes the prize template look closer to other templates bid and run details. The name of the prize is more evident, the information is more clearly laid out, and the overall look is more polished.
The new template has been tested on both desktop and mobile form factors, and mobile is vastly more readable thanks to the larger font sizes.
In all below screenshot sets, top is the image before the template was changed, and the bottom one is after.
Prize Page with Image(Desktop)
Also includes a category(even though this is no longer used for new prizes in the main tracker, it is in the code(and used on historical prizes), so it's been included in these changes) and uses the game-based prize draw timing. Prize provider has a website, so it's linked as well.
Prize Page without Image(Desktop)
Does not have categories, and uses start/end-times for drawing. Prize provider does not have a website, so no link is added.
Prize Page With Image(Mobile)
Prize Page Without Image(Mobile)
Verification Process
What process did you follow to verify that the change has not introduced any regressions? Describe the actions you took apart from writing tests, such as running a local instance of the tracker. (What buttons did you press, etc.)
I've run a local instance of the tracker to ensure that the prize pages work properly on both desktop and mobile.
I've cropped the mobile screenshots down to the important sections, but they have full dimensions of 1080p wide and 2057p tall. All removed height is at the bottom, so if scaling them back up, just add a fully white section to the bottom to match the height.
For reference, the screenshots were taken using firefox's Take Screenshot function(available in the right-click menu) and then selecting "Save Full Page." The resolution of these appears to be ~2x what is shown on the screen, but that should not be too much of an issue for what's shown in these screenshots.
The desktop screenshots were taken on the 2560x1600 panel of my Framework Laptop 16, and the mobile screenshots are basic screenshots from my Google Pixel 7 using Android's screenshot functionality.