Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rcon): add RCON command #4488

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

MicLieg
Copy link
Contributor

@MicLieg MicLieg commented Feb 6, 2024

Description

This pull request aims to add RCON commands to lgsm. This will allow game server admins to easily run scheduled RCON commands on game servers that don't provide an interactive console, without the need for external client software.

I've implemented a very basic RCON client in Python. It mostly follows the Source RCON Protocol except for multiple packet responses that are used when the server response exceeds 4096 bytes. This shouldn't be a problem as I intend the RCON command to be a write only command rather than a full RCON interface to the server.

While i'm using Minecraft, which already supports LinuxGSM's send command, to demo this feature, the main goal ist to send commands to gameservers that do NOT have an interactive console.

RCON-Command.mp4

Still on the TODO list (help appreciated):

  • Identify Servers that don't support RCON
  • Identify if there are Servers that use a different Protocol than the Source RCON Protocol
  • Verify that the Used RCON connection Details (${telnetip}, ${rconport}, ${rconpassword}) are always set

Related to #674, #2107, #2334, #2922

Fixes #674

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (a change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked if documentation needs updating. TODO

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@MicLieg MicLieg changed the base branch from master to develop February 6, 2024 04:00
@MicLieg
Copy link
Contributor Author

MicLieg commented Jul 13, 2024

Do you have any feedback for this feature & implementation, @dgibbs64?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sdtdserver] Feature request: announce server restarts ingame via telnet
1 participant