Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update UE4/UE5 parameters and configs #4378

Merged
merged 21 commits into from
Nov 13, 2023
Merged

Conversation

dgibbs64
Copy link
Member

@dgibbs64 dgibbs64 commented Nov 13, 2023

Description

This PR standardises UE4 and UE5 game servers. Many of the Unreal 4 game servers are setup in slightly different ways. I have reviewed all the game servers and standardises the parameters and configs as best I can. This has been a useful exercise to better understand how UE4 servers work. Also 3 servers are now UE5.

Fixes #[issue]

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (a change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked if documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

Copy link

gitguardian bot commented Nov 13, 2023

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
7656188 Generic High Entropy Secret 6783d1e lgsm/modules/info_stats.sh View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@dgibbs64 dgibbs64 changed the title Feature/ut4 parameters feat: Update UE4/UE5 parameters and configs Nov 13, 2023
@dgibbs64 dgibbs64 added this to the v23.7.0 milestone Nov 13, 2023
@dgibbs64 dgibbs64 merged commit 283e625 into develop Nov 13, 2023
81 of 82 checks passed
@dgibbs64 dgibbs64 deleted the feature/ut4-parameters branch November 13, 2023 23:59
@dgibbs64 dgibbs64 linked an issue Nov 17, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Satisfactory is due to move to UE5 in the 14th november
1 participant