-
-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update UE4/UE5 parameters and configs #4378
Conversation
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
7656188 | Generic High Entropy Secret | 6783d1e | lgsm/modules/info_stats.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Description
This PR standardises UE4 and UE5 game servers. Many of the Unreal 4 game servers are setup in slightly different ways. I have reviewed all the game servers and standardises the parameters and configs as best I can. This has been a useful exercise to better understand how UE4 servers work. Also 3 servers are now UE5.
Fixes #[issue]
Type of change
Checklist
PR will not be merged until all steps are complete.
develop
branch as its base.Documentation
If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.
Thank you for your Pull Request!