feat(core): prefix logs with a timestamp

[DrissiReda]

Description

Adds the possibility to prefix each line of log with a timestamp before pushing it to the log file.

Currently I only enabled it on rustserver, because that's what I used to test it. But it should work for everything else.

I pushed the modification to every file, but if #3745 is merged, I'll refactor my PR.

Fixes #3778

Type of change

• Bug fix (a change which fixes an issue).
• New feature (change which adds functionality).
• New Server (new server added).
• Refactor (restructures existing code).
• Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

• This pull request links to an issue.
• This pull request uses the develop branch as its base.
• This pull request Subject follows the Conventional Commits standard.
• This code follows the style guidelines of this project.
• I have performed a self-review of my code.
• I have checked that this code is commented where required.
• I have provided a detailed with enough description of this PR.
• I have checked If documentation needs updating.

[h3o66]

the standard on lgsm is more "on/off" and not "True/False"
Please refactor this one first

[dgibbs64]

Great idea!!

[DrissiReda]

Great idea!!

You think it needs anything else to be merged?

[jusito]

Suggesting to use date instead of gawk:
printf '[%s] %s\n' "$(date "+$logtsformat")" "hello world"
or echo "asd" | xargs printf '[%s] %s\n' "$(date "+$format")"
provides the same output as
echo "hello world" | gawk '{ print strftime("[%Y-%m-%d %H:%M:%S]"), $0}'
and we wouldnt need an additional dependency

[DrissiReda]

I had a hard time escaping that command to be able to use it in my exec . If you managed to do it I'd be happy to use it.

[jusito]

Simple explanation:
bash knows mostly strings,
"interpret special characters >once< before passing this to something"
'dont interpret special characters before passing'

Therefore:
echo "$UID" '$UID' # whitespace in between = two strings = two args for echo 1st is checked for special characters and after that added as arg to echo, 2nd not
If you dont want this behavior use single quotes.

If you need to mix it, you can combine it.
echo "$UID"'$UID' # no whitespace in between = one string, first part is interpreted before
or you can escape with
echo "\$UID" '$UID' # output is identical
if you do want to output \ between "", you need to escape it as well:
echo "\\" '\' # but not if you use single quotes
What if you want to use double or single quotes?
echo "\"" '"' or echo "'"
You can also escape whitespaces, so this is one string
foo=hello\ world but please dont do so

In your command: add_ts="gawk '{ print strftime(\\\"[$logtsformat]\\\"), \\\$0 }'" add_ts=".."..".." you used the "interpret special characters way" but you wanted to add double quotes to it, so you needed to escape it once. add_ts="..\"..\".." but why are the additional \ needed?

foo=hello
bar=\$foo
echo "$bar" # prints $foo because interpreted once, even if special symbol is in
eval echo "$bar" # prints hello but why?
# calls eval "echo" '$foo'
# eval interpreted once more and executes "echo" "hello"
#
# if you want to prevent it ( and how you did )
bar=\\\$foo
eval echo "$bar" # prints now $foo instead of hello
# thats what happened to you

Edit btw if you want to execute a command try:

cmd=(echo "hello world")
cmd+=("123")
"${cmd[@]}"
# | & > aso need to be outside of the array
"${cmd[@]}" | ... 

Sry was more motivated to clarify this for you than fixing the issue.

[DrissiReda]

I understand all that, but I need it to process the variable $logtsformat inside of add_ts. Which means I have:

add_ts=gawk '{ print strftime(\"[%Y-%m-%d %H:%M:%S]\"), \$0 }'

Then in L96 the line will become:

tmux pipe-pane -o -t "${sessionname}" "exec bash -c \"cat | gawk '{ print strftime(\"[%Y-%m-%d %H:%M:%S]\"), \$0 }'\" >> '${consolelog}'"

I can put everything manually in that line, but we'll have the some logic repeated in multiple steps and it'll make the code less readable and harder to maintain.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.