Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: start and get game API #115 #134

Merged
merged 3 commits into from
Jan 25, 2024
Merged

feat: start and get game API #115 #134

merged 3 commits into from
Jan 25, 2024

Conversation

timt1028
Copy link
Collaborator

@timt1028 timt1028 commented Nov 8, 2023

Resolves #115

@timt1028 timt1028 added the back-end back end issue label Nov 8, 2023
snowmancc
snowmancc approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@snowmancc snowmancc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...es/backend/app/src/main/java/tw/waterballsa/gaas/citadels/app/usecases/StartGameUseCase.java
}

private List<RoleCard> getRoleCards() {
return Arrays.asList(new RoleCard(1, "刺客"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使用 enum

chiashengchen
chiashengchen approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@chiashengchen chiashengchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timt1028 timt1028 merged commit 92f6366 into main Jan 25, 2024
1 check passed
@timt1028 timt1028 deleted the CreateAndGetGame branch January 25, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiashengchen chiashengchen chiashengchen approved these changes

@snowmancc snowmancc snowmancc approved these changes

@aprilywy aprilywy Awaiting requested review from aprilywy

Assignees
No one assigned
Labels
back-end back end issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

【後端】開始遊戲的API
3 participants
@timt1028 @snowmancc @chiashengchen