Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: find game sort by times played #220

Merged
merged 1 commit into from
Aug 4, 2024
Merged

feature: find game sort by times played #220

merged 1 commit into from
Aug 4, 2024

Conversation

kuoche1712003
Copy link
Contributor

Why need this change? / Root cause:

Changes made:

  • Refactor event bus.
  • Add a StartedGameEventListener to record the number of times the game is played.
  • sort by TIMES_PLAYED.

Test Scope / Change impact:

  • None.

Issue

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

frankvicky
frankvicky approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@frankvicky frankvicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricksu978 ricksu978 merged commit 7a156d3 into main Aug 4, 2024
4 checks passed
@ricksu978 ricksu978 deleted the feature/find-game-sort-by-times-played branch August 4, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankvicky frankvicky frankvicky approved these changes

@ricksu978 ricksu978 Awaiting requested review from ricksu978

Assignees
No one assigned
Labels
None yet
Projects
GaaS 大平台後端 Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

被玩最多次的遊戲排前面
3 participants
@kuoche1712003 @frankvicky @ricksu978