Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/join room event #194

Merged
merged 2 commits into from
Dec 16, 2023
Merged

Fix/join room event #194

merged 2 commits into from
Dec 16, 2023

Conversation

kuoche1712003
Copy link
Contributor

Why need this change? / Root cause:

  • fix socket io message

Changes made:

  • fit the actual socket io event from font end

Test Scope / Change impact:

  • none

Issue

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

ricksu978
ricksu978 approved these changes Dec 16, 2023
View reviewed changes
Copy link
Member

@ricksu978 ricksu978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuoche1712003 kuoche1712003 merged commit 8a0948c into main Dec 16, 2023
4 checks passed
@kuoche1712003 kuoche1712003 deleted the fix/join-room-event branch December 16, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricksu978 ricksu978 ricksu978 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuoche1712003 @ricksu978