Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/#129 query issue #132

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Fix/#129 query issue #132

merged 4 commits into from
Jan 25, 2024

Conversation

GaHee99
Copy link
Contributor

@GaHee99 GaHee99 commented Jan 24, 2024

Related Issue ๐Ÿš€

Work Description โœ๏ธ

  • block, report๊ด€๋ จ ์ฟผ๋ฆฌ๋ฌธ ๋งŽ์ด ๋‚˜๊ฐ€๋Š” ๋ถ€๋ถ„๋“ค์„ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ๋˜ํ•œ laze-loadingํ•˜๋Š” ์—”ํ‹ฐํ‹ฐ๋“ค์„ fetchJoinํ•˜์—ฌ ์ฟผ๋ฆฌ๋ฌธ์„ ์ค„์˜€์Šต๋‹ˆ๋‹ค.

PR Point ๐Ÿ“ธ

  • ์ฟผ๋ฆฌ ์„ฑ๋Šฅ์„ ์–ด๋–ป๊ฒŒ ํ•˜๋ฉด ๋” ๋†’์ผ ์ˆ˜ ์žˆ์„์ง€์— ๋Œ€ํ•œ ์˜๊ฒฌ์„ ์ฃผ์‹œ๋ฉด ๊ฐ์‚ฌํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค!

@GaHee99 GaHee99 self-assigned this Jan 24, 2024
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 24, 2024
dragontaek-lee
dragontaek-lee reviewed Jan 25, 2024
View reviewed changes
Copy link
Member

@dragontaek-lee dragontaek-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ฟผ๋ฆฌ์งœ๋Š”๋ฐ ๊ณ ์ƒ ๋งŽ์œผ์…จ์Šต๋‹ˆ๋‹ค...!!

src/main/java/com/gam/api/service/user/UserServiceImpl.java
firstWork = findWork(firstWorkId);
if (firstWorkId == null || !dto.user().getActiveWorks().isEmpty()) { // User ๊ถŒํ•œ ์—๋Ÿฌ
firstWork = workRepository.findFirstByUserIdAndIsActiveOrderByCreatedAtDesc(dto.user().getId(), true)
.orElse(Work.builder()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์—๋Ÿฌ์˜ ์ƒํ™ฉ์ด ์•„๋‹Œ๊ฐ€์š”?! firstWorkId ๋ฐ์ดํ„ฐ ์ •ํ•ฉ์„ฑ์ด ๋งž์ง€ ์•Š๋Š”๋ฐ ๋„˜๊ธฐ๋Š” ๊ฒƒ์€ ์ข‹์ง€ ์•Š์•„๋ณด์ž…๋‹ˆ๋‹ค!
์—๋Ÿฌ๋ฅผ ํ„ฐ๋œจ๋ ค์„œ ์ •ํ•ฉ์„ฑ์„ ๋งž์ถ”๋Š”๊ฒŒ ๋งž์„๊ฑฐ ๊ฐ™์•„์š”.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ธฐ์กด ์ฝ”๋“œ๋Š” ์—๋Ÿฌ๋ฅผ ํ„ฐ๋œจ๋ฆฌ๋Š” ๊ฒƒ ์ด์—ˆ๋Š”๋ฐ,
์ด๋ ‡๊ฒŒ ๋˜๋‹ˆ ํ•œ๋ช…์˜ ์œ ์ €๊ฐ€ ์—๋Ÿฌ์ผ ๋ชจ๋“  ์œ ์ €๊ฐ€ '๋ฐœ๊ฒฌ-์œ ์ €'์„œ๋น„์Šค๋ฅผ ์ง„์ž…ํ•˜์ง€ ๋ชปํ•  ์ˆ˜๋„ ์žˆ๋‹ค๊ณ  ์ƒ๊ฐํ–ˆ์Šต๋‹ˆ๋‹ค.
๋”ฐ๋ผ์„œ ์—๋Ÿฌ๋ฅผ ํ„ฐ๋œจ๋ฆฌ์ง€ ์•Š๊ณ , ์ผ๋‹จ ์œ ์ € ๊ถŒํ•œ์„ ๋ฐ”๊พธ๋Š” ๊ฒƒ์œผ๋กœ ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค!

try catch๋กœ log๋ฅผ ๋„์šฐ๋Š” ๋ฐฉ๋ฒ•๋„ ์žˆ๊ฒ ๋„ค์šฉ ํ˜น์‹œ ๋ง์”€ํ•˜์‹  ๋ถ€๋ถ„์ด ํ›„์ž๋ผ๋ฉด ์ˆ˜์ •ํ•˜์—ฌ ํ‘ธ์‹œํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค!

@GaHee99 GaHee99 merged commit f0ba232 into develop Jan 25, 2024
1 check passed
@GaHee99 GaHee99 deleted the fix/#129-Query-issue branch February 15, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragontaek-lee dragontaek-lee dragontaek-lee left review comments

@kjy-asl kjy-asl Awaiting requested review from kjy-asl

Assignees

@GaHee99 GaHee99

Labels
fix gahee size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GaHee99 @dragontaek-lee