Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Commit

Permalink
Tell eslint to allow devDependencies imports
Browse files Browse the repository at this point in the history
In 4c3eec8, I moved a few packages from `dependencies` to
`devDependencies`. Eslint wasn't happy about that, so I'm adding an
exception to the `import/no-extraneous-dependencies` rule.
  • Loading branch information
trotzig committed Dec 2, 2016
1 parent ce15df3 commit 18df986
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ module.exports = {

rules: {
'jsx-quotes': ['error', 'prefer-single'],
'import/no-extraneous-dependencies': ['error', { devDependencies: true }],
},
};

2 comments on commit 18df986

@lencioni
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bummer. I saw your reasoning about moving these packages to devDependencies and that makes sense, but I'm not convinced it is worth the tradeoff here. It would be nice if this rule allowed for a whitelist. Perhaps we should open an issue?

@trotzig
Copy link
Contributor Author

@trotzig trotzig commented on 18df986 Dec 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I guess that would be ideal. I'm not too helped by this rule to be honest. If a dependency isn't listed, the build will break. So having eslint help us is nice but not strictly necessary.

Please sign in to comment.