feat(rpc): python llvm_alloc_global equiv (alloc_global) #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
RyanGlScott
reviewed
Nov 18, 2021
| @@ -110,7 +111,8 @@ instance FromJSON ty => FromJSON (ContractVar ty) where | |||
| instance (FromJSON ty, FromJSON e) => FromJSON (Contract ty e) where | |||
| parseJSON = | |||
| withObject "contract" $ \o -> | |||
| Contract <$> o .: "pre vars" | |||
| Contract <$> o .: "mutable globals" | |||
There was a problem hiding this comment.
Mention this new capability of the remote API in the SAW changelog.
m-yac
reviewed
Dec 10, 2021
| g = x; | ||
| } | ||
|
|
||
| uint32_t get() { |
There was a problem hiding this comment.
Should there also be a test for this function in test_llvm_global_mutable.py?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.