server, telemetry: unify packages into single dune project #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like, with the changes made to package organization, the `ocaml/setup-ocaml` action might do this for us
samcowger
force-pushed
the
sc/dune-package-reorg
branch
from
5c95b85 to
f1471f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts both packages in the same top-level project, as defined by a new
dune-projectfile, and does some light renaming. This will allow interdependency between packages going forward. In particular, it will allow the server to depend ontelemetryto collect and store telemetry. It seems moredune/opam-idiomatic, and may ease the building and packaging process.