Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use array predicates to clarify array utils #147

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Use array predicates to clarify array utils #147

merged 2 commits into from
Jan 8, 2025

Conversation

peterohanley
Copy link
Contributor

Describe your changes

These predicates are very simple but with enormous each terms it was hard to see what they are actually doing.

Issue ticket number and link

None.

Checklist before requesting a review

  • I have performed a self-review of my code
  • My code matches the coding standards and I have ran the appropriate linters
  • I included documentation updates for my code
  • I extended the test suite and the tests run by the CI to cover my code
  • I assigned a Milestone to this PR
  • I assigned this PR to a Project
  • I assigned this PR appropriate Labels

@peterohanley peterohanley added the application software application software components label Dec 20, 2024
@peterohanley peterohanley self-assigned this Dec 20, 2024
Copy link
Collaborator

@podhrmic podhrmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but needs documentation as mentioned in my comment above.

components/include/cn_array_utils.h Show resolved Hide resolved
@podhrmic podhrmic merged commit 598854e into main Jan 8, 2025
17 checks passed
@podhrmic podhrmic deleted the gus-reword branch January 8, 2025 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application software application software components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants