Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cycles to 4.2.0 #264

Closed
wants to merge 4 commits into from
Closed

Conversation

boberfly
Copy link
Contributor

The blender guys made a 4.2 release in the last few days. I'll look into Gaffer changes soon.

@boberfly
Copy link
Contributor Author

@murraystevenson
Copy link
Contributor

Thanks Alex! It will be great to get the Cycles 4.2 update in for Gaffer 1.5.

I've actually run into some of this already with a local branch using Cycles 4.1.1, which I also updated to 4.2.0 last night.

My workaround for the change to how precompiled dependencies are handled is a bit simpler (I'm just removing those stub directories under ./lib/), which I think we'd prefer here, but your precompiledLibsToggle.patch looks like it would be beneficial to get back into Cycles itself for the long run if you think that's something they'd accept?

I also found that the linked zstd cmake config was a bit overly verbose for my taste, where it was restating a lot of the defaults, so mine is attempting to be a fair bit simpler.

My branch is also aiming to include OIDN with CUDA support. I'll try to put it up later today and maybe we can go with it instead?

@boberfly
Copy link
Contributor Author

boberfly commented Jul 25, 2024

your precompiledLibsToggle.patch looks like it would be beneficial to get back into Cycles itself for the long run if you think that's something they'd accept?

Yep got it here, deleting the directories was getting in the way at the git level but the tarball wouldn't have that issue you're right.
https://projects.blender.org/blender/cycles/pulls/13

My branch is also aiming to include OIDN with CUDA support. I'll try to put it up later today and maybe we can go with it instead?

Cool, yeah I got OIDN also here but left it out to keep things simpler but that would be good to include too.

I just remembered too, could we also get Meson support in the docker builder? For Epoxy so the USD support can be added back in. I have a patch to fix up their python detection for that somewhere here that I'd like to upstream also.

Cheers

@murraystevenson
Copy link
Contributor

Closing in favour of the Cycles 4.2 update in #267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants