Merge pull request #993 from VincentRouvreau/fix_landscapes_sanitizer…

…_issue Fix Persistence_representations landscape memory leak
GUDHI · Oct 31, 2023 · 106b6eb · 106b6eb
2 parents ac4e237 + cfd3e09
commit 106b6eb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -59,7 +59,7 @@ jobs:
             cd build
             cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_CXX_FLAGS=-fsanitize=address -DWITH_GUDHI_EXAMPLE=OFF -DWITH_GUDHI_TEST=ON -DWITH_GUDHI_UTILITIES=OFF -DWITH_GUDHI_PYTHON=OFF ..
             make all
-            ctest --output-on-failure -E Persistence_lanscapes_test_unit
+            ctest --output-on-failure
 
   utils:
     docker:

diff --git a/src/Persistence_representations/include/gudhi/Persistence_landscape.h b/src/Persistence_representations/include/gudhi/Persistence_landscape.h
@@ -388,6 +388,7 @@ class Persistence_landscape {
       nextLevelMerge.swap(nextNextLevelMerge);
     }
     (*this) = (*nextLevelMerge[0]);
+    if (!is_this_first_level) delete nextLevelMerge[0];
     (*this) *= 1 / static_cast<double>(to_average.size());
   }