-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the mod info header readable #8
Conversation
Unless I am misunderstanding something, there is no "modpack" here. This strange format makes it difficult for launchers to understand what is going on, thereby treating it as an arbitrary junk file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's intended to be like this, see https://github.com/GTNewHorizons/ExampleMod1.7.10/blob/master/src/main/resources/mcmod.info. The "modList" property exists because you can have multiple mods in one jar, like e.g. ProjectRed does it.
This looks like a bug/oversight in MMC/Prism then as this format isn't exactly new. This behaviour isn't exclusive to CMM either, many other GTNH mods use the modListVersion 2 format. |
You don't need to change the format you can just remove the non curly brackets from the top and bottom as those shouldn't be there when using modListVersion 2 format. |
Still, it is rather strange to make this kind of format universal, given that this is something that is expected to be used on an as-needed basis. If a mod isn't a pack, there is no need for the format. If a mod becomes a pack, then the metadata can be changed to reflect that. I should mention that Project Red is also a pack, and the metadata is read correctly. Out of all of the GTNH mods I have, this is the only one exhibiting such behaviour. So there is something specific about the metadata here that is not playing nicely with launchers. |
There's really no reason to change the format.. if you revert to the old format and just remove the top and bottom bracket it will be read correctly by whatever launcher you're using. |
Going along with the suggested changes. It appears to do the trick, although I remain uncertain about the choice of format.
Please restore placeholders like |
It was copied from static files, and I forgot about the variables that the data file uses in code.
Sorry about that. I clumsily copied it from a static source, and forgot the variables. |
Unless I am misunderstanding something, there is no "modpack" here. This strange format makes it difficult for launchers to understand what is going on, thereby treating it as an arbitrary junk file.