Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the mod info header readable #8

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

ColonelGerdauf
Copy link

Unless I am misunderstanding something, there is no "modpack" here. This strange format makes it difficult for launchers to understand what is going on, thereby treating it as an arbitrary junk file.

Unless I am misunderstanding something, there is no "modpack" here. This strange format makes it difficult for launchers to understand what is going on, thereby treating it as an arbitrary junk file.
@Dream-Master Dream-Master requested a review from a team March 10, 2024 18:44
Copy link
Member

@glowredman glowredman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's intended to be like this, see https://github.com/GTNewHorizons/ExampleMod1.7.10/blob/master/src/main/resources/mcmod.info. The "modList" property exists because you can have multiple mods in one jar, like e.g. ProjectRed does it.

@ColonelGerdauf
Copy link
Author

image
Meanwhile, the other GTNH mods
image

@glowredman
Copy link
Member

glowredman commented Mar 10, 2024

This looks like a bug/oversight in MMC/Prism then as this format isn't exactly new. This behaviour isn't exclusive to CMM either, many other GTNH mods use the modListVersion 2 format.

@Lyfts
Copy link
Member

Lyfts commented Mar 10, 2024

You don't need to change the format you can just remove the non curly brackets from the top and bottom as those shouldn't be there when using modListVersion 2 format.

@ColonelGerdauf
Copy link
Author

Still, it is rather strange to make this kind of format universal, given that this is something that is expected to be used on an as-needed basis.

If a mod isn't a pack, there is no need for the format. If a mod becomes a pack, then the metadata can be changed to reflect that.

I should mention that Project Red is also a pack, and the metadata is read correctly. Out of all of the GTNH mods I have, this is the only one exhibiting such behaviour. So there is something specific about the metadata here that is not playing nicely with launchers.

@Lyfts
Copy link
Member

Lyfts commented Mar 10, 2024

There's really no reason to change the format.. if you revert to the old format and just remove the top and bottom bracket it will be read correctly by whatever launcher you're using.

Going along with the suggested changes. It appears to do the trick, although I remain uncertain about the choice of format.
@miozune
Copy link
Member

miozune commented Mar 11, 2024

Please restore placeholders like ${modId}

It was copied from static files, and I forgot about the variables that the data file uses in code.
@ColonelGerdauf
Copy link
Author

Sorry about that. I clumsily copied it from a static source, and forgot the variables.

@miozune miozune merged commit 327100d into GTNewHorizons:master Mar 11, 2024
1 check passed
@ColonelGerdauf ColonelGerdauf deleted the patch-1 branch March 11, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants