Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image reordering #178

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Image reordering #178

merged 1 commit into from
Sep 12, 2023

Conversation

kavinphan
Copy link

@kavinphan kavinphan commented Sep 10, 2023

PR Title/Tagline

Issue Number(s): #169

Add ability for admins to reorder images when editing a card.

feat_image_reordering.mp4

Checklist

  • Images can be reordered easily within an already created digital library card.
  • The reordering also changes the ordering in the backend (the reordering must be persistent, it should not just happen in the frontend).
  • The reordering uses a drag and drop method.
    • This could not be done because the images are stored in a paginated carousel (could only drag-n-drop on the same page)
  • Images can only be reordered in "edit" mode.
  • The first image in the ordering should become the thumbnail for this card (this should happen automatically but if it doesn't then this will need to be implemented).

How to Test

  1. Find a card that has multiple images and open it
  2. Verify that the reorder buttons are not visible
  3. Click edit
  4. Verify that the reorder buttons are now visible
  5. Verify that the first and last images cannot be reordered out of bounds
  6. Verify that reordering an image renders properly
  7. Verify that discarding changes resets the image order
  8. Verify that saving changes persists the new order

@github-actions
Copy link

Deploy preview for southface ready!

✅ Preview
https://southface-m0azzymo8-bitsofgood.vercel.app

Built with commit 2d1e4cd.
This pull request is being automatically deployed with vercel-action

@kavinphan kavinphan marked this pull request as ready for review September 10, 2023 21:54
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting changes triggered by husky

@kavinphan kavinphan linked an issue Sep 10, 2023 that may be closed by this pull request
5 tasks
@avayedawadi avayedawadi merged commit f2fb012 into main Sep 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Image Reordering
2 participants