-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add post card shadow on hover #260
base: staging
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for angels-among-us ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 26% | 526/2023 |
🔴 | Branches | 9.33% (+0.03% 🔼) |
64/686 |
🔴 | Functions | 12.42% | 77/620 |
🔴 | Lines | 22.33% | 401/1796 |
Test suite run success
40 tests passing in 5 suites.
Report generated by 🧪jest coverage report action from 903bc62
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if there's a way to keep the padding as it is and just allow overflow: visible
to show the box shadow. Let me know if that works - I'm a little biased against using margin wherever possible.
Also, two points: could you have a longer transition for the hover (short, maybe 200ms?) and make the box shadow a bit more subtle (https://chakra-ui.com/docs/styled-system/style-props#shadow, use boxShadow='md'
)?
I couldn't use |
Add post card shadow on hover
Issue Number(s): #226
Adds post card shadow on hover. Had to change some margins/paddings because otherwise the shadow gets cut off.
Checklist
Critical Changes
None
Related PRs
None
Testing
Check shadow appears on hover.