Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor GCT header when parsing dataset rows #51

Open
ACastanza opened this issue Feb 1, 2022 · 1 comment
Open

Honor GCT header when parsing dataset rows #51

ACastanza opened this issue Feb 1, 2022 · 1 comment

Comments

@ACastanza
Copy link

Currently GSEA Desktop will parse the GCT header and then throw an error if there are additional blank rows at the end of the gct file. I think that the correct behavior here would be to honor the header and exclude blank rows that occur after the end of the specified number of genes perhaps providing a warning message instead.

@davideby
Copy link
Contributor

davideby commented Feb 1, 2022

Yeah, I tend to agree. GCT was designed in a time of memory-constrained computers where it was more important to know how many items it should expect than to be more user-friendly. We can clearly change the focus there.

Skipping blank rows is simple thing.

I'm just not totally clear what to do if there are more "real" rows than specified. I would say that should still be an error.

Honestly we should just steer people to the TXT format since GCT doesn't bring much to the table at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants