1157: Update url filter logic and expose new urls to snapshot

GSA · Sep 19, 2024 · eae1153 · eae1153
1 parent 830fbdd
commit eae1153
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/entities/core-result.entity.ts b/entities/core-result.entity.ts
@@ -289,8 +289,7 @@ export class CoreResult {
   thirdPartyServiceDomains?: string;
 
   @Column({ nullable: true })
-  //@Expose({ name: 'third_party_service_urls' })
-  @Exclude()
+  @Expose({ name: 'third_party_service_urls' })
   @Transform((value: string) => {
     if (value) {
       return value.split(',');
@@ -526,6 +525,7 @@ export class CoreResult {
     'dap_version',
     'ga_tag_id',
     'third_party_service_domains',
+    'third_party_service_urls',
     'third_party_service_count',
     'cookie_domains',
     'viewport_meta_tag',

diff --git a/libs/core-scanner/src/scans/third-party.ts b/libs/core-scanner/src/scans/third-party.ts
@@ -57,8 +57,8 @@ export function thirdPartyServicesUrls ( parentLogger: Logger, outboundRequests:
     const url = request && new URL(request.url());
     if (parsedUrl.hostname != url.hostname && !request.isNavigationRequest()) {
       const fullUrl = removeQueryParameters(url.toString());
-      const isFileLoad = fullUrl.startsWith('data:') || fullUrl.startsWith('blob:');
-      if( !isFileLoad) {
+      const isFileLoad = fullUrl.startsWith('http') || fullUrl.startsWith('https');
+      if( isFileLoad) {
         thirdPartyDomains.push(fullUrl);
       }
     }